568613 - Remove "browser.history_expire_days" usage from the tree

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Doug Turner (:dougt)]

I am not sure how significant this is...

In e10s, child processes do not have the ability to clear preferences (read only).  When global history is started, it reads in preferences.  It also tries to clear "browser.history_expire_days".

It isn't obvious to me if we should be clearing this preferences in the chrome process, or simply not starting up global history, or simply ignoring the error.

Thoughts?

Comment 1

[[e-mail]]

Shouldn't this whole thing be remoted? (Or even not exist in content?)

Comment 2

[Shawn Wilsher :sdwilsh]

Er, why is this even running in the content process?  The chrome process should be setting it as appropriate, however.

Comment 3

[Doug Turner (:dougt)]

The code path might have been caused by 568612, but anytime that nav history is created, we will have problems.

Can we just disable global history in content (maybe stop it from being registered)

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

qawanted to retest

Comment 6

[Marco Bonardo [:mak]]

this bug doesn't make sense today on desktop, since browser.history_expire_days doesn't exist anymore. Is this for a related setting on mobile or just outdated?

Comment 7

[Marco Bonardo [:mak]]

and fwiw we should remove these lines if mobile doesn't make use of it
http://mxr.mozilla.org/mozilla-central/search?string=history_expire_days

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Not important for e10s then. NI'ing finkle to see if we can clear that code in mobile

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Yeah, we can remove those lines from mobile.js

Comment 10

[Marco Bonardo [:mak]]

morphing the bug to cover removing the outdated code, making it a mentored bug.

Comment 11

[Jefry Lagrange]

Attachment: Removes outdated code from tree.

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 8411839 [details] [diff] [review]
Removes outdated code from tree.

Review of attachment 8411839 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc6cd04f8ff

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4dc6cd04f8ff