Closed
Bug 568613
Opened 15 years ago
Closed 11 years ago
Remove "browser.history_expire_days" usage from the tree
Categories
(Core Graveyard :: History: Global, defect)
Core Graveyard
History: Global
Tracking
(e10s-)
RESOLVED
FIXED
mozilla31
Tracking | Status | |
---|---|---|
e10s | - | --- |
People
(Reporter: dougt, Assigned: jefry.reyes)
References
Details
(Whiteboard: [good first bug][mentor=mak][lang=cpp][lang=js])
Attachments
(1 file)
3.52 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
I am not sure how significant this is... In e10s, child processes do not have the ability to clear preferences (read only). When global history is started, it reads in preferences. It also tries to clear "browser.history_expire_days". It isn't obvious to me if we should be clearing this preferences in the chrome process, or simply not starting up global history, or simply ignoring the error. Thoughts?
Comment 1•15 years ago
|
||
Shouldn't this whole thing be remoted? (Or even not exist in content?)
Comment 2•15 years ago
|
||
Er, why is this even running in the content process? The chrome process should be setting it as appropriate, however.
Reporter | ||
Comment 3•15 years ago
|
||
The code path might have been caused by 568612, but anytime that nav history is created, we will have problems. Can we just disable global history in content (maybe stop it from being registered)
Updated•13 years ago
|
Assignee: nobody → josh
Updated•11 years ago
|
Assignee: josh → nobody
Updated•11 years ago
|
tracking-e10s:
--- → +
Comment 6•11 years ago
|
||
this bug doesn't make sense today on desktop, since browser.history_expire_days doesn't exist anymore. Is this for a related setting on mobile or just outdated?
Comment 7•11 years ago
|
||
and fwiw we should remove these lines if mobile doesn't make use of it http://mxr.mozilla.org/mozilla-central/search?string=history_expire_days
Comment 8•11 years ago
|
||
Not important for e10s then. NI'ing finkle to see if we can clear that code in mobile
Flags: needinfo?(mark.finkle)
Comment 9•11 years ago
|
||
Yeah, we can remove those lines from mobile.js
Flags: needinfo?(mark.finkle)
Comment 10•11 years ago
|
||
morphing the bug to cover removing the outdated code, making it a mentored bug.
Keywords: qawanted
Summary: [e10s] "browser.history_expire_days" clear user pref doesn't work in child processes → Remove "browser.history_expire_days" usage from the tree
Whiteboard: [good first bug][mentor=mak][lang=cpp][lang=js]
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jefry.reyes
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #8411839 -
Flags: review?(mak77)
Comment 12•11 years ago
|
||
Comment on attachment 8411839 [details] [diff] [review] Removes outdated code from tree. Review of attachment 8411839 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8411839 -
Flags: review?(mak77) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc6cd04f8ff
Keywords: checkin-needed
Comment 14•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dc6cd04f8ff
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•