568652 - jsTerm: history key bindings

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[David Dahl :ddahl]

make sure the up/down arrow key bindings for the jsterm are working right. This is implemented but buggy in the patch on bug 534398

Comment 1

[David Dahl :ddahl]

most of this is working, needs tests.

Comment 2

[Julian Viereck]

Attachment: added a jsterm property on the HeadsUpDisplay

Necessary patch for later unit tests.

Comment 3

[Julian Viereck]

Attachment: Final Patch

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 457544 [details] [diff] [review]
Final Patch


>             // up arrow: history previous
>             if (self.caretInFirstLine()){
>               self.historyPeruse(true);
>+              var bool = aEvent.cancelable;
>+              if (bool) {
>+                let inputEnd = self.inputNode.value.length;
>+                self.inputNode.setSelectionRange(inputEnd, inputEnd);
>+                aEvent.preventDefault();
>+              }
>             }

here and below, can you remove the one-time-used |bool| locals, and do if (aEvent.cancelable) instead?

r=me otherwise.

Comment 5

[Julian Viereck]

Attachment: [checked-in] Final Patch v2

Revision of 457544 based on :dietrich's comments.

Note: this patch depends on the patch from bug 579073.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 457665 [details] [diff] [review]
[checked-in] Final Patch v2

changeset:   47816:ac4bef453b82
user:        Julian Viereck <[e-mail]>
date:        Fri Jul 16 12:00:38 2010 -0300
summary:     bug 568652 - jsTerm history keybindings, r=dietrich