568707 - "key is not defined" results in broken form history service

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Sounds like mrbkap and jorendorff know what's going on. We'll need to work around it for the 1.3 release.

The exception throws for this reference:

http://localhost:8000/file/50ccc820a14a/source/components/FormNotifier.js#l33

But basically the code looks like..

for (let keyval in Iterator(obj)) {
  let [key, val] = keyval;
  this[key] = function() {
    let notify = function() {
      foo({ bar: key });
    };
    notify();
  };
}

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 447880 [details] [diff] [review]
v1

we really need to get unit tests running in prod.

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/3be7bbdc48fe
Pretend to call a function with "key" to keep it around.

Comment 4

[Ed Lee :Mardak]

Ergh. hg.mozilla.org isn't working, but the link in comment 0 should have been

http://hg.mozilla.org/labs/weave/file/50ccc820a14a/source/components/FormNotifier.js#l33

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/29a97fe177d0 (new url from hg magic)
Pretend to call a function with "key" to keep it around.