568770 - Visible privacy status of events in calendar view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Ondrej Bohuslav]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: 

There should be some identification about privacy status of events in calendar view (for example by some icon in each event). Privacy status of event is now visible only in detail of event in status bar.

Reproducible: Always

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Screenshot - v1

Ludovic suggest the use of an icon, as has been implemented in the inverse edition. I'm not too sure a further icon is the right thing here, but I don't see an alternative. Reasoning:

* We have to be careful what we make an icon. The extreme case might be: an event with a DISPLAY, EMAIL and SMS reminder (3 icons), that has a privacy state. This totals to 4 icons. I'm not saying we shouldn't use an icon, but we should make a clear decision as to what aspects of the event should get an icon.

* The privacy state is clearly important for the business user, but the casual user doesn't need to know about privacy states. I think this is already solved in the screenshot, i.e public events have no icon.

* We had a major discussion back in the days about the lock icon. We are using a lock icon for the "readonly" state, and we don't want users to think that the event is readonly instead of private. Also, we use an exclamation mark for "high priority" in the task list. I don't think its appropriate for a "confidential" state.

Andreas, do you think it makes sense to add icons here? Could you whip up some icons that match the design (this bug is not high priority, so no rush).

Comment 2

[Andreas Nilsson (:andreasn)]

What did you want a UI-review on specifically?
Brainstorming some metaphors for an icon:
* Mask, like Firefox http://www.f-secure.com/weblog/archives/Firefox_3.5_Privacy_Options.png
* A door hanger, like the old FF icon among others http://www.smugmug.com/img/aboutus/privacy.jpg
* A pair of sunglasses http://cache.gawkerassets.com/assets/images/17/2010/05/500x_web_privacy_shades.jpg
* An eye crossed with the iris crossed over <(/)>

Comment 3

[Andreas Nilsson (:andreasn)]

Ping?

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Sorry for the delay:

* Does it make sense to add the privacy icon to events in the view, and if so, in which cases? Keep in mind there may already be very many icons.

* Going a step further, what set of icons do you think make sense for display in the calendar views? We currently have one for each alarm type set, and with this bug possibly the privacy state.

Comment 5

[Andreas Nilsson (:andreasn)]

If we're not indicating it with graphics, we could also indicate it with color.
What does other apps do in this case?

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

I think a color wouldn't be the best idea, since there is already the calendar and category color. I believe outlook uses an icon. I'm not saying an icon is bad, but I'd like a professional opinion if an icon makes sense for this case.

Comment 7

[Andreas Nilsson (:andreasn)]

If we can't indicate it with color, I think a privacy icon is the best option, since that takes up less space than a text saying "Private" or something like that. So +1 on that.
I agree that lots of icons is bad, but I think we need a good way to identify this and the icon comes off as least evil.

Comment 8

[Andreas Nilsson (:andreasn)]

Can I find a list of what icons we display in the calendar?
What alarm types exist?

Comment 9

[Andreas Nilsson (:andreasn)]

(In reply to comment #8)
> Can I find a list of what icons we display in the calendar?
> What alarm types exist?

Ping?

Comment 10

[Felix Möller]

I think the standard alarm icons are at <http://hg.mozilla.org/releases/comm-beta/raw-file/4bc3872982b8/calendar/base/themes/common/images/alarm-icons.png>

Comment 11

[Andreas Nilsson (:andreasn)]

After some discussion on IRC with Phillip, we're going for giving events that are marked private an icon, but a public event not (since that's the default). This needs to be something different than a padlock, and I'll attach that to this bug.

Lets do a deeper investigation of any other icons that needs to be added or removed in a separate bug, clearly labeled as such so we don't loose focus on the actual issue in this bug.

Comment 12

[Andreas Nilsson (:andreasn)]

Comment on attachment 476547 [details]
Screenshot - v1

setting ui-review minus since we don't want to use a padlock icon to indicate a private event.

Comment 13

[Laurent Jouanneau]

Attachment: First version of the patch

Here is a patch, made originally by the OBM team.

Icons should probably be reworked but I'm not a designer :-)

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 626049 [details] [diff] [review]
First version of the patch

Review of attachment 626049 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch. I believe this is actually the patch from SOGo, but its not all that important.

r=philipp with a few amendments as below. I have made these locally and will take care of the checkin.

Regarding the icons, I fear this will be a longer process since we need to overhaul all the kinds of readonly/privacy icons. I say we do this in a separate bug.

::: calendar/base/content/calendar-view-core.xml
@@ +215,5 @@
> +              let privacy = item.privacy;
> +              if (!privacy || privacy == "") {
> +                  privacy = "PUBLIC";
> +              }
> +              classificationBox.setAttribute("classification", privacy);

This can be condensed into 2-3 lines and we should get rid of the comment as its now part of Lightning.

::: calendar/base/themes/gnomestripe/calendar-views.css
@@ +58,5 @@
>  .today-navigation-button {
>      padding-top: 0px !important; /* a workaround to center the label vertically on Windows */
>  }
> +
> +.item-classification-box {

These rules can now be put into base/themes/common/calendar-views.css once

::: calendar/base/themes/winstripe/calendar-views.css
@@ +60,5 @@
>      padding-top: 0px !important; /* a workaround to center the label vertically on Windows */
>  }
> +
> +
> +.item-classification-box[classification="PUBLIC"] {

Redundant blank line

::: calendar/test/mozmill/testEventDialog.js
@@ +148,5 @@
>    // make it private and verify icon visible
>    event.click(new elementslib.ID(event.window.document, "button-privacy"));
>    event.click(new elementslib.ID(event.window.document, "event-privacy-private-menuitem"));
> +  //let icon = (new elementslib.ID(event.window.document, "button-privacy-private"));
> +  //event.assertJS(event.window.getComputedStyle(icon.getNode(), null).getPropertyValue("visibility") == "visible");

Thanks for keeping mozmill in mind. I think we can slightly modify this though to check if the label is visible.

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

For those who haven't tried the patch, the icon is not a padlock like above, but a key icon.

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

Filed bug 767089 for the new icons.

Pushed as comm-central changeset 656121f74646