Closed
Bug 568975
Opened 13 years ago
Closed 13 years ago
m-c message manager slowed down event handling a bit
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
4.51 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
5.42 KB,
patch
|
Details | Diff | Splinter Review |
We can reduce the needed QIing
Attachment #448119 -
Flags: review?(jst)
Comment 1•13 years ago
|
||
Comment on attachment 448119 [details] [diff] [review] patch - In nsPIDOMWindow.h: // These two variables are special in that they're set to the same // value on both the outer window and the current inner window. Make // sure you keep them in sync! nsCOMPtr<nsPIDOMEventTarget> mChromeEventHandler; // strong + nsCOMPtr<nsPIDOMEventTarget> mParentTarget; // strong nsCOMPtr<nsIDOMDocument> mDocument; // strong Given the above comment this member doesn't fit in here. r=jst with that fixed.
Attachment #448119 -
Flags: review?(jst) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Oops, I move mParentTarget under mDocument.
Assignee | ||
Comment 3•13 years ago
|
||
Clear mEventTarget when disconnecting messageManager. I posted this to tryserver to see if this doesn't regress one browser chrome test.
Comment 4•13 years ago
|
||
(In reply to comment #3) > I posted this to tryserver to see if this doesn't regress > one browser chrome test. How did this work? Can we move jst's r+ forward and land this? Full disclosure, I really need bug 571438 landed and it depends on this patch.
Assignee | ||
Comment 5•13 years ago
|
||
I think we could move r+, but bug 571438 needs still a review.
Comment 6•13 years ago
|
||
Comment on attachment 450634 [details] [diff] [review] patch nsInProcessTabChildGlobal::Disconnect() { + nsCOMPtr<nsIDOMWindow> win = do_GetInterface(mDocShell); + nsCOMPtr<nsPIDOMWindow> pwin = do_QueryInterface(win); + if (pwin) { + pwin->SetChromeEventHandler(pwin->GetChromeEventHandler()); + } I don't understand this change, seems like a no-op to me, but there may be more to this than meets the eye...
Assignee | ||
Comment 7•13 years ago
|
||
That change clears mParentTarget in windows. I'll add a comment.
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e4816b85e694
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•13 years ago
|
||
I'll add still the comment.
You need to log in
before you can comment on or make changes to this bug.
Description
•