568975 - m-c message manager slowed down event handling a bit

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug]]

Attachment: patch

We can reduce the needed QIing

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 448119 [details] [diff] [review]
patch

- In nsPIDOMWindow.h:

   // These two variables are special in that they're set to the same
   // value on both the outer window and the current inner window. Make
   // sure you keep them in sync!
   nsCOMPtr<nsPIDOMEventTarget> mChromeEventHandler; // strong
+  nsCOMPtr<nsPIDOMEventTarget> mParentTarget; // strong
   nsCOMPtr<nsIDOMDocument> mDocument; // strong
 
Given the above comment this member doesn't fit in here.

r=jst with that fixed.

Comment 2

[Olli Pettay [:smaug]]

Oops, I move mParentTarget under mDocument.

Comment 3

[Olli Pettay [:smaug]]

Attachment: patch

Clear mEventTarget when disconnecting messageManager.

I posted this to tryserver to see if this doesn't regress
one browser chrome test.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #3)

> I posted this to tryserver to see if this doesn't regress
> one browser chrome test.

How did this work? Can we move jst's r+ forward and land this? 

Full disclosure, I really need bug 571438 landed and it depends on this patch.

Comment 5

[Olli Pettay [:smaug]]

I think we could move r+, but bug 571438 needs still a review.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 450634 [details] [diff] [review]
patch

 nsInProcessTabChildGlobal::Disconnect()
 {
+  nsCOMPtr<nsIDOMWindow> win = do_GetInterface(mDocShell);
+  nsCOMPtr<nsPIDOMWindow> pwin = do_QueryInterface(win);
+  if (pwin) {
+    pwin->SetChromeEventHandler(pwin->GetChromeEventHandler());
+  }

I don't understand this change, seems like a no-op to me, but there may be more to this than meets the eye...

Comment 7

[Olli Pettay [:smaug]]

That change clears mParentTarget in windows.

I'll add a comment.

Comment 8

[Olli Pettay [:smaug]]

http://hg.mozilla.org/mozilla-central/rev/e4816b85e694

Comment 9

[Olli Pettay [:smaug]]

I'll add still the comment.