568995 - Update tests to use waitForClipboard

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Apart from browser_bug556061.js which is getting fixed in bug 567870, there are 2 tests that I found which should be using waitForClipboard:
browser/base/content/test/browser_bug321000.js
toolkit/components/passwordmgr/test/browser/browser_passwordmgrcopypwd.js

(I know Browser/General isn't exactly right... but it didn't seem worth filing multiple bugs in the right components)

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1 (browser_bug321000.js)

update browser_bug321000.js
* use waitforClipboard
* also removed clearing the clipboard at the end of the test. I know it was added (bug 474081) to see if this was affecting other tests, but it looked like the verdict was that it isn't.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1 (browser_passwordmgrcopypwd.js)

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 448147 [details] [diff] [review]
Patch v0.1 (browser_bug321000.js)

>+  waitForClipboard(kTestString, function() cbHelper.copyString(kTestString),
>+                   next_test, finish);

nit: function () { cbHelper.copyString(kTestString); }
What you wrote is short for function () { return cbHelper.copyString(kTestString); }, but you don't want to return anything.

You can declare cbHelper right above this, it's not used elsewhere.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Pushed (with nits fixed) http://hg.mozilla.org/mozilla-central/rev/19fda49851ee