569054 - DOM Inspector doesn't start up with shortcut key on Firefox latest trunk.

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; ja; rv:1.9.2.4) Gecko/20100527 Firefox/3.6.4
Build Identifier: 

DOM Inspector doesn't start up with shortcut key on Firefox latest trunk. It is caused with to use the same shortcut key, shft + accel + I, between DOM Inspector and Web Inspector in Firefox latest trunk. So occuring the conflict of shortcut key.

Reproducible: Always

Comment 1

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100529 Minefield/3.7a5pre {Build ID: 20100529040313}

Reproducible with Firefox trunk/DOM Inspector 2.0.5

Comment 2

[Elmar Ludwig]

I also see this on Linux in a current trunk build, confirming.

Comment 3

[:Mook]

Attachment: Clobber the Firefox built in "Inspect" key [Checkin: comment 7]

Somebody in #devtools (sorry, I don't recall whom) mentioned that the key probably isn't going to change on their end.

This clobbers that key so the DOMi one takes effect.  The Inspect menu still exists, it just no longer has a keyboard shortcut associated with it.

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

(In reply to comment #3)
> Somebody in #devtools (sorry, I don't recall whom)

It was robcee.  He also suggested that DOM Inspector should steal the page inspector's keyboard shortcut, but I'm not sure it's a great idea. It would be kind of crappy of us. Although I'm not jazzed about using a different shortcut, either.

Comment 5

[Colby Russell :crussell (no longer Mozilla-ing)]

So how do you feel about comment 4, Shawn?  I can totally forsee lots of complaints on AMO about bad behavior towards the hip, new devtools inspector if we just outright steal it without any option to leave it alone.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #5)
> So how do you feel about comment 4, Shawn?  I can totally forsee lots of
> complaints on AMO about bad behavior towards the hip, new devtools inspector if
> we just outright steal it without any option to leave it alone.
I think that, as long as the menu item is still there for the new stuff, installing DOMi means you want to use it, and it's OK to take over the key combo.

Comment 7

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 466560 [details] [diff] [review]
Clobber the Firefox built in "Inspect" key [Checkin: comment 7]

Pushed:
http://hg.mozilla.org/dom-inspector/rev/99631666c158

Comment 8

[Colby Russell :crussell (no longer Mozilla-ing)]

(In reply to Colby Russell :crussell from comment #4)
> (In reply to comment #3)
> > Somebody in #devtools (sorry, I don't recall whom)
> 
> It was robcee.  He also suggested that DOM Inspector should steal the page
> inspector's keyboard shortcut

To be clear, I was talking about bug 565872, comment 13.  Dão actually suggested stealing the shortcut on the DOM Inspector end; robcee suggested avoiding using the shortcut on the devtools end if DOM Inspector is detected to be installed (which is effectively the same, except that the latter approach leaves open the possibility of using an entirely different shortcut for the devtools inspector in the DOM-Inspector-is-installed case).

Comment 9

[V@no]

Attachment: Adding support for changes in v25

In v25 "Inspect" key was changed from key_inspect to key_devToolboxMenuItem
This patch adding support for these changes.
In addition adding missing hotkey display into menuitem

Comment 10

[V@no]

Since devtools inspector now has two set of hotkeys (CTRL+SHIFT+I and F12) perhaps reclaiming DOMi original hotkey is now appropriate thing to do?
I mean, c'mon, DOMi had it for years before devtools even been thought of...

Comment 11

[Tony Mechelynck [:tonymec]]

(In reply to V@no from comment #10)
> Since devtools inspector now has two set of hotkeys (CTRL+SHIFT+I and F12)
> perhaps reclaiming DOMi original hotkey is now appropriate thing to do?
> I mean, c'mon, DOMi had it for years before devtools even been thought of...

This doesn't affect SeaMonkey, which by default comes with DOMi preinstalled and without that other inspector. Here (SeaMonkey 2.41a1 linux-x86_64 20151019003001 en-US), Ctrl+Shift+I starts DOMi as always.

V@no: I see the present bug is FIXED. Maybe start a new bug somewhere on Firefox (Firefox::Untriaged or, maybe better, Firefox::Developer Tools: Inspector) for that hotkey conflict issue?