Closed Bug 569204 Opened 10 years ago Closed 10 years ago

Port Bug 504804 [prefs cleanup and smarter integration with win policy settings]

Categories

(SeaMonkey :: Download & File Handling, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file, 1 obsolete file)

We should respect "browser.download.manager.scanWhenDone" when on Vista or Win7
Attachment #448368 - Flags: review?(neil)
Attachment #448368 - Flags: feedback?(kairo)
Attachment #448368 - Flags: review?(neil) → review-
Comment on attachment 448368 [details] [diff] [review]
Patch v1.0 Check for scanWhenDone

>+Components.utils.import("resource://gre/modules/Services.jsm");
...
>-var gPrefService = Components.classes["@mozilla.org/preferences-service;1"]
>-                             .getService(Components.interfaces.nsIPrefBranch);
>+var gPrefService = Services.prefs;
Sorry, either do it properly or don't do it at all.

The rest of the patch looks reasonable but I don't actually have a Vista/7 build environment to try it on...
>>+var gPrefService = Services.prefs;
> Sorry, either do it properly or don't do it at all.
Fixed.
Attachment #448368 - Attachment is obsolete: true
Attachment #448453 - Flags: review?(neil)
Attachment #448453 - Flags: feedback?(kairo)
Attachment #448368 - Flags: feedback?(kairo)
Comment on attachment 448453 [details] [diff] [review]
Patch v1.1 less is more.

> The rest of the patch looks reasonable but I don't actually have a Vista/7
> build environment to try it on...
Anybody else? mcsmurf?
Attachment #448453 - Flags: feedback?(bugzilla)
Now that I look more closely, I see that you didn't add a default pref value.
Ignore that, I was MXRing the wrong tree.
Comment on attachment 448453 [details] [diff] [review]
Patch v1.1 less is more.

All I can give feedback on is that it does the same as the toolkit patch. I have no way to test it or know how it works anyway.
Attachment #448453 - Flags: feedback?(kairo) → feedback+
Status: NEW → ASSIGNED
Attachment #448453 - Flags: review?(neil) → review+
Forgot to say:
Pushed to comm-central on Sun Jun 06 23:42:22 2010 +0800
http://hg.mozilla.org/comm-central/rev/ac0969f73fc8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #448453 - Flags: feedback?(bugzilla)
You need to log in before you can comment on or make changes to this bug.