569204 - Port Bug 504804 [prefs cleanup and smarter integration with win policy settings]

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Philip Chee]

We should respect "browser.download.manager.scanWhenDone" when on Vista or Win7

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Check for scanWhenDone

Comment 2

[[e-mail]]

Comment on attachment 448368 [details] [diff] [review]
Patch v1.0 Check for scanWhenDone

>+Components.utils.import("resource://gre/modules/Services.jsm");
...
>-var gPrefService = Components.classes["@mozilla.org/preferences-service;1"]
>-                             .getService(Components.interfaces.nsIPrefBranch);
>+var gPrefService = Services.prefs;
Sorry, either do it properly or don't do it at all.

The rest of the patch looks reasonable but I don't actually have a Vista/7 build environment to try it on...

Comment 3

[Philip Chee]

Attachment: Patch v1.1 less is more.

>>+var gPrefService = Services.prefs;
> Sorry, either do it properly or don't do it at all.
Fixed.

Comment 4

[Philip Chee]

Comment on attachment 448453 [details] [diff] [review]
Patch v1.1 less is more.

> The rest of the patch looks reasonable but I don't actually have a Vista/7
> build environment to try it on...
Anybody else? mcsmurf?

Comment 5

[[e-mail]]

Now that I look more closely, I see that you didn't add a default pref value.

Comment 6

[[e-mail]]

Ignore that, I was MXRing the wrong tree.

Comment 7

[Robert Kaiser]

Comment on attachment 448453 [details] [diff] [review]
Patch v1.1 less is more.

All I can give feedback on is that it does the same as the toolkit patch. I have no way to test it or know how it works anyway.

Comment 8

[Philip Chee]

Forgot to say:
Pushed to comm-central on Sun Jun 06 23:42:22 2010 +0800
http://hg.mozilla.org/comm-central/rev/ac0969f73fc8