Closed Bug 569313 Opened 12 years ago Closed 3 years ago

Redundant "Toolbar" in name of "Navigation Toolbar"

Categories

(Firefox :: Disability Access, defect)

x86
Windows 7
defect
Not set
minor

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox71 --- verified

People

(Reporter: Jamie, Assigned: MarcoZ)

Details

(Keywords: access)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100531 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100531 Minefield/3.7a5pre

Since the Gecko accessibility code started exposing the names of toolbars, the Navigation toolbar (containing the location and search bars) is reported by screen readers as "Navigation Toolbar toolbar". This is because the name is "Navigation Toolbar" and the role is toolbar. The "Toolbar" part of the name is redundant, as the fact that it is a toolbar is indicated by its role. Also, it is inconsistent with other toolbars; e.g. the browser tabs toolbar is named "Browser Tabs", not "Browser Tabs Toolbar".

Reproducible: Always

Steps to Reproduce:
1. Open Firefox.
2. Press alt+d to move to the address bar.
3. Examine the name of the accessible for the parent toolbar.
Actual Results:  
The name is "Navigation Toolbar".

Expected Results:  
The name should be just "Navigation".
Keywords: access
Version: unspecified → Trunk
The name for the toolbar is grabbed from the toolbarname XUL attribute, if present. In the case of the browser tabs, we didn't have this, so we use aria-label on the browsertabs toolbar to give it a name. The toolbarname attribute corresponds to the menu item entry under View/Toolbars.
Is there a fairly easy way to add the XUL attribute for toolbarname to the Navigation and Bookmarks toolbars?
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
As I understand it, the toolbarname attribute is already set for the Navigation toolbar. However, it is set to "Navigation Toolbar" instead of just "Navigation", thus causing the redundancy. Changing that would change the View -> Toolbars menu, which probably isn't ideal. aria-label could be set to "Navigation" to fix this, but that introduces duplication in the code. :)
cc'ing Dao

This is a trivial fix, but it requires a new localization ID for the toolbar labels. One that basically contains the same text, but without the word "toolbar" in it.

It is time to get rid of this annoyance.

Assignee: nobody → mzehe
Status: NEW → ASSIGNED
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/843c6335cf52
Get rid of redundant "Toolbar" in name of "Navigation" and "bookmarks" toolbars, r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Flags: qe-verify+

Hello! Reproduced the issue on Firefox 71.0a1 (20190903215623) and names used in the Accessibility window where "Bookmarks Toolbar" and "Navigation Toolbar".
Using Firefox 71.0b4 (20191024095932) on Windows 10x64, macOS 10.14 and Ubuntu 18.04, the names in the Accessibility window are "Navigation" and "Bookmarks".

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.