569313 - Redundant "Toolbar" in name of "Navigation Toolbar"

Status: VERIFIED FIXED

(Firefox :: Disability Access, defect)

Description

[James Teh [:Jamie]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100531 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100531 Minefield/3.7a5pre

Since the Gecko accessibility code started exposing the names of toolbars, the Navigation toolbar (containing the location and search bars) is reported by screen readers as "Navigation Toolbar toolbar". This is because the name is "Navigation Toolbar" and the role is toolbar. The "Toolbar" part of the name is redundant, as the fact that it is a toolbar is indicated by its role. Also, it is inconsistent with other toolbars; e.g. the browser tabs toolbar is named "Browser Tabs", not "Browser Tabs Toolbar".

Reproducible: Always

Steps to Reproduce:
1. Open Firefox.
2. Press alt+d to move to the address bar.
3. Examine the name of the accessible for the parent toolbar.
Actual Results:  
The name is "Navigation Toolbar".

Expected Results:  
The name should be just "Navigation".

Comment 1

[Marco Zehe (:MarcoZ)]

The name for the toolbar is grabbed from the toolbarname XUL attribute, if present. In the case of the browser tabs, we didn't have this, so we use aria-label on the browsertabs toolbar to give it a name. The toolbarname attribute corresponds to the menu item entry under View/Toolbars.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Is there a fairly easy way to add the XUL attribute for toolbarname to the Navigation and Bookmarks toolbars?

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

I'm looking in here and wondering if it is a relatively easy fix: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul

Comment 4

[James Teh [:Jamie]]

As I understand it, the toolbarname attribute is already set for the Navigation toolbar. However, it is set to "Navigation Toolbar" instead of just "Navigation", thus causing the redundancy. Changing that would change the View -> Toolbars menu, which probably isn't ideal. aria-label could be set to "Navigation" to fix this, but that introduces duplication in the code. :)

Comment 5

[alexander :surkov (:asurkov)]

cc'ing Dao

Comment 6

[Marco Zehe (:MarcoZ)]

This is a trivial fix, but it requires a new localization ID for the toolbar labels. One that basically contains the same text, but without the word "toolbar" in it.

Comment 7

[Marco Zehe (:MarcoZ)]

Attachment: Bug 569313 - Get rid of redundant "Toolbar" in name of "Navigation" and "bookmarks" toolbars, r=gijs

Comment 8

[Marco Zehe (:MarcoZ)]

It is time to get rid of this annoyance.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/843c6335cf52
Get rid of redundant "Toolbar" in name of "Navigation" and "bookmarks" toolbars, r=Gijs

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/843c6335cf52

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

Hello! Reproduced the issue on Firefox 71.0a1 (20190903215623) and names used in the Accessibility window where "Bookmarks Toolbar" and "Navigation Toolbar".
Using Firefox 71.0b4 (20191024095932) on Windows 10x64, macOS 10.14 and Ubuntu 18.04, the names in the Accessibility window are "Navigation" and "Bookmarks".