Closed
Bug 569490
Opened 15 years ago
Closed 15 years ago
Build should disable D3D9 layer if d3d9.h not found
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
7.82 KB,
patch
|
ted
:
review+
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce problem:
1. Don't install an SDK that includes d3d9.h
2. Try to build
Expected result: OpenGL layer builds
|
Assignee | |
Comment 1•15 years ago
|
||
Compiles with and without d3d9.h
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #448637 -
Flags: review?(ted.mielczarek)
Attachment #448637 -
Flags: review?(jmuizelaar)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 448637 [details] [diff] [review]
Possible patch
This seems fine. Do we know what SDK version the header appeared in? Because if we could pin that down we could instead use NTDDI_VERSION checks.
Attachment #448637 -
Flags: review?(ted.mielczarek) → review+
|
||
Updated•15 years ago
|
Attachment #448637 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Pushed changeset 7ebd45a02360 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 4•15 years ago
|
||
So the patch here has issues. With this patch if preferogl is true, and ogl creation fails, you won't get a D3D9 layer manager, this is undesirable behaviour.
You need to log in
before you can comment on or make changes to this bug.
Description
•