569542 - App picker never uses bundle display name

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[zhang xiaoyun [:ThinkVision]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100315 Firefox/3.5.9 ( .NET CLR 3.5.30729) XPCOMViewer/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100315 Firefox/3.5.9 ( .NET CLR 3.5.30729) XPCOMViewer/0.9.2

While I review the code at http://mxr.mozilla.org/comm-1.9.2/source/mozilla/toolkit/components/apppicker/content/appPicker.js. See below code variable mistakes.
193 #ifdef XP_MACOSX
194     const nsILocalFileMac = Components.interfaces.nsILocalFileMac;
195     if (file instanceof nsILocalFileMac) {
196       try {
197         return lfm.bundleDisplayName;
198       } catch (e) {
199       }
200     }
201 #endif

Here "lfm" should be "file".

Reproducible: Always

Steps to Reproduce:
1.open websit http://mxr.mozilla.org/comm-1.9.2/source/mozilla/toolkit/components/apppicker/content/appPicker.js
2.see line between 193 and 201
3.find "lfm.bundleDisplayName", it should be file.bundleDisplayName.
Actual Results:  
lfm should be file.

Expected Results:  
lfm should be file.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Good catch! There are three copies of this function spread across the tree, and this bug was the result of a bad copy/paste from one to the other, I think. I don't see any reason why these need to be different, so this patch makes them all do the same thing. Ideally we'd just have one implementation called by the three current consumers, but I'm not sure exactly what the best place for it is.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch updated to trunk

Here's one that applies cleanly.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: fix indentation, also fix applications.js

Comment 4

[[e-mail]]

Comment on attachment 449622 [details] [diff] [review]
fix indentation, also fix applications.js

Well, the Windows app picker still works, but I'm not in a position to verify the fix to the bug per se.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/3bd6e0c3770e