Closed
Bug 569587
Opened 14 years ago
Closed 14 years ago
nsBidiKeyboard.cpp compilation failure on mingw-w64 due to pointer to int casts loosing precision.
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
I get following errors: /home/jacek/mozilla-build/mozilla-central64/widget/src/windows/nsBidiKeyboard.cpp: In member function 'nsresult nsBidiKeyboard::SetupBidiKeyboards()': /home/jacek/mozilla-build/mozilla-central64/widget/src/windows/nsBidiKeyboard.cpp:161:18: error: cast from 'HKL__*' to 'DWORD' loses precision /home/jacek/mozilla-build/mozilla-central64/widget/src/windows/nsBidiKeyboard.cpp:166:18: error: cast from 'HKL__*' to 'DWORD' loses precision /home/jacek/mozilla-build/mozilla-central64/widget/src/windows/nsBidiKeyboard.cpp: In member function 'PRBool nsBidiKeyboard::IsRTLLanguage(HKL__*)': /home/jacek/mozilla-build/mozilla-central64/widget/src/windows/nsBidiKeyboard.cpp:216:28: error: cast from 'HKL__*' to 'DWORD' loses precision The obvious fix are proper casts.
|
Assignee | |
Updated•14 years ago
|
Attachment #448753 -
Attachment is patch: true
Attachment #448753 -
Flags: review?(roc)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
Attachment #448753 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/62b328633b3a
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•