569608 - gfxTextRunWordCache.cpp compilation failure on mingw-w64 due to pointer to long cast loosing precision.

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

I get following error:

gfx/thebes/src/gfxTextRunWordCache.cpp:938:57: error: cast from 'void*' to 'long int' loses precision

long is 32-bit on win64, so it's really loosing precision. The attached patch changes cast to intptr_t instead of long.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This should likely do a reinterpret_cast then; we really do want only the low 32 bits (as the hash key is only 32 bits), and I believe going up to 64 bits here will widen the whole expression for no good reason.

Comment 2

[Jacek Caban]

Attachment: fix v1.1

Thanks for review. I had an impression that in this case there will be implicit cast to 32-bit integer.

reinterpret_cast alone doesn't fix the problem. The error remains. The attached patch uses two casts to make sure that we get 32-bit int. It could use reinterpret_cast if you prefer.

Comment 3

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/63e1a2df087b