569645 - change interaction of 'height' on table cells with baseline alignment (and size of cell box)

Status: NEW

(Core :: Layout: Tables, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Today the CSS working group resolved CSS 2.1 issue 26:
http://wiki.csswg.org/spec/css2.1#issue-26
in a way that is compatible with IE but not with our code, so we should change our behavior to match.

In particular, it says that the 'height' property on table cells does not change the height of the cell box, but only sets a minimum height on the row.  This means that:
 * we should stop increasing the height of the anonymous box inside table cells in response to the 'height' property. (which also allows us to eliminate one of the two sets of table cell vertical alignment code, IIRC)
 * we should replace that code with code that is part of row height calculation

The combination of the two changes should only change testcases that involve 'vertical-align: baseline'.

For more details, see:
http://wiki.csswg.org/spec/css2.1#issue-26
http://lists.w3.org/Archives/Public/www-style/2010Jun/0048.html

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, the code isn't as I remembered it, so this may just require an update to nsTableRowFrame::UpdateHeight.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I think I looked into this at one point and decided it was more complicated than I first thought.)

Comment 8

[Gérard Talbot]

I am adding these

http://www.gtalbot.org/BrowserBugsSection/css21testsuite/baseline-empty-table-cells-RobertHogan-1.html

http://www.gtalbot.org/BrowserBugsSection/css21testsuite/baseline-empty-table-cells-RobertHogan-2.html

hoping they are useful for this bug report.

Gérard

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 6 duplicates.
:dholbert, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 12

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.