Last Comment Bug 569645 - change interaction of 'height' on table cells with baseline alignment (and size of cell box)
: change interaction of 'height' on table cells with baseline alignment (and si...
Status: NEW
: css2
Product: Core
Classification: Components
Component: Layout: Tables (show other bugs)
: Trunk
: All All
: -- normal with 4 votes (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
: 634489 804227 1040934 1103614 1211829 1216164 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-02 10:57 PDT by David Baron :dbaron: ⌚️UTC-10
Modified: 2015-11-24 14:29 PST (History)
10 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description David Baron :dbaron: ⌚️UTC-10 2010-06-02 10:57:55 PDT
Today the CSS working group resolved CSS 2.1 issue 26:
http://wiki.csswg.org/spec/css2.1#issue-26
in a way that is compatible with IE but not with our code, so we should change our behavior to match.

In particular, it says that the 'height' property on table cells does not change the height of the cell box, but only sets a minimum height on the row.  This means that:
 * we should stop increasing the height of the anonymous box inside table cells in response to the 'height' property. (which also allows us to eliminate one of the two sets of table cell vertical alignment code, IIRC)
 * we should replace that code with code that is part of row height calculation

The combination of the two changes should only change testcases that involve 'vertical-align: baseline'.

For more details, see:
http://wiki.csswg.org/spec/css2.1#issue-26
http://lists.w3.org/Archives/Public/www-style/2010Jun/0048.html
Comment 1 David Baron :dbaron: ⌚️UTC-10 2010-06-02 11:34:59 PDT
Actually, the code isn't as I remembered it, so this may just require an update to nsTableRowFrame::UpdateHeight.
Comment 2 David Baron :dbaron: ⌚️UTC-10 2011-02-15 20:25:27 PST
*** Bug 634489 has been marked as a duplicate of this bug. ***
Comment 3 David Baron :dbaron: ⌚️UTC-10 2011-02-15 21:18:22 PST
*** Bug 634489 has been marked as a duplicate of this bug. ***
Comment 4 David Baron :dbaron: ⌚️UTC-10 2012-10-23 03:03:39 PDT
*** Bug 804227 has been marked as a duplicate of this bug. ***
Comment 5 Boris Zbarsky [:bz] (still a bit busy) 2014-07-22 18:32:51 PDT
*** Bug 1040934 has been marked as a duplicate of this bug. ***
Comment 6 David Baron :dbaron: ⌚️UTC-10 2014-11-23 18:47:56 PST
*** Bug 1103614 has been marked as a duplicate of this bug. ***
Comment 7 David Baron :dbaron: ⌚️UTC-10 2014-11-23 18:49:59 PST
(I think I looked into this at one point and decided it was more complicated than I first thought.)
Comment 9 Boris Zbarsky [:bz] (still a bit busy) 2015-10-21 14:21:55 PDT
*** Bug 1216164 has been marked as a duplicate of this bug. ***
Comment 10 Boris Zbarsky [:bz] (still a bit busy) 2015-11-24 14:29:33 PST
*** Bug 1211829 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.