Closed Bug 569730 Opened 15 years ago Closed 15 years ago

Can't log in a 2nd computer

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Mardak, Assigned: philikon)

References

Details

(Keywords: regression, Whiteboard: [weave1.4])

Attachments

(1 file, 1 obsolete file)

Something regressed with bug 557590 2010-06-02 15:09:29 Service.Main DEBUG checkSetup: no username set 2010-06-02 15:09:49 Service.Main DEBUG Exception: aborting login, client not configured No traceback available
Does this affect all 1.3 users? As in, if I am running 1.3, can I not set up a 2nd computer?
Nah. bug 557590 landed after 1.3.
Whiteboard: [weave1.4]
Mea culpa. I was a bit overzealous with the refactoring and neglected that case :/. I'll prepare a patch.
Assignee: nobody → philipp
Attached patch Fix + test v1 (obsolete) — Splinter Review
Reintroduces an 'else' clause the refactoring in bug 557590 mistakenly threw out.
Attachment #449250 - Flags: review?(edilee)
Attached patch Fix + test v1.1Splinter Review
Improve teardown (clean up preferences).
Attachment #449250 - Attachment is obsolete: true
Attachment #449260 - Flags: review?(edilee)
Attachment #449250 - Flags: review?(edilee)
Comment on attachment 449260 [details] [diff] [review] Fix + test v1.1 >+ // We need a non-empty passphrase for login to work. Even the >+ // setup wizard just sets this to 'foo' if there isn't a >+ // passphrase yet. >+ Weave.Service.passphrase = "foo"; Can you file a bug to make sure this is investigated and made sure it's ok?
Attachment #449260 - Flags: review?(edilee) → review+
http://hg.mozilla.org/labs/weave/rev/710dec717f8d Fix a regression introduced with the status.js refactoring (bug 557590).
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: