Closed Bug 570002 Opened 10 years ago Closed 10 years ago

moz-icon://file:/// no longer works

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: neil, Assigned: neil)

References

()

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

Bug 559496 changed the behaviour of moz-icon: URI parsing. The old parser used to accept both moz-icon:file:/// and moz-icon://file:/// URIs.

There are a number of places that try to produce moz-icon://file:/// URIs so it would be slightly easier to relax the parser.
Attached patch Possible patch (obsolete) — Splinter Review
Attachment #449088 - Flags: review?(joshmoz)
Attachment #449088 - Flags: review?(joe)
blocking2.0: --- → ?
Attachment #449088 - Flags: review?(joe) → review+
Attachment #449088 - Flags: review?(joshmoz) → review+
Pushed changeset 218c8700878c to mozilla-central.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Caused test failures on m-c

s: moz2-linux-slave05
TEST-UNEXPECTED-FAIL | /builds/moz2_slave/mozilla-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/test_libpr0n/unit/test_moz_icon_uri.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/moz2_slave/mozilla-central-linux-opt-unittest-xpcshell/build/xpcshell/tests/test_libpr0n/unit/test_moz_icon_uri.js | false == true - See following stack:

Multi OS's though.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Test fix (obsolete) — Splinter Review
Tests for the "broken" behaviour...
Assignee: nobody → neil
Status: REOPENED → ASSIGNED
Attachment #450497 - Flags: review?(joe)
Comment on attachment 450497 [details] [diff] [review]
Test fix

If our failures no longer fail, and we want them to, we should fix the original code.

Consider this a rescinding of my original r+ on the code, too, until the invalid URL tests throw exceptions.
Attachment #450497 - Flags: review?(joe) → review-
Attached patch Revised patchSplinter Review
This adds extra checks to fail the URI in the cases we test for.
Attachment #449088 - Attachment is obsolete: true
Attachment #450497 - Attachment is obsolete: true
Attachment #450717 - Flags: review?(joe)
I haven't actually seen any references to places that need moz-icon://, so I won't block on this for now.
blocking2.0: ? → -
The download manager, among others, uses moz-icon://.
blocking2.0: - → final+
Attachment #450717 - Flags: review?(joe) → review+
Pushed changeset bc573ea704f2 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.