570017 - CSP report-uri with dotless host throws exception

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brandon Sterne (:bsterne)]

CSP WARN:  couldn't parse report URI: http://bsterne/wordpress/wp-content/csp-process-report.php
[Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomain]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: file:///build/m-c/ff-debug/dist/bin/modules/CSPUtils.jsm :: anonymous :: line 181"  data: no]

Comment 1

[Sid Stamm [:geekboy or :sstamm]]

Attachment: fix

Dotless hosts don't play nice with the ETLD service... there's no "base domain" for a host that has no recognized TLD.  

The fix involves watching for when the ETLD service throws a fit, then just do a string comparison on the host to be sure that the report URI is on the same host as "self".  This is a fallback to same-origin restricting the report URI when the ETLD service isn't helpful.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 449110 [details] [diff] [review]
fix

r=dveditz

Comment 3

[Brandon Sterne (:bsterne)]

http://hg.mozilla.org/mozilla-central/rev/ffceae16b1a7

Comment 4

[Mihai Morar, (:MihaiMorar)]

Is there any manual way to verify this fix or a script is required?