570046 - test_update.js hangs on Thunderbird builds

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mark Banner (:standard8)]

For some reason when running test_update.js on Thunderbird builds, it is hanging.

The debugging that I've done so far, appears to point to test 7, where the test is trying to add (and update?) a lightweight theme.

So far, the update doesn't seem to be firing/requesting lwtheme.js from the http server. I can't see why.

Comment 1

[Mark Banner (:standard8)]

I've tried running this in objdir with a Firefox build (i.e. the same as we do for Thunderbird) and Firefox passed successfully.

I think this may be pointing to something that FF is supporting that TB isn't, but I've not got nay idea where to look for that.

Comment 2

[Dave Townsend [:mossop]]

Got a log so I can see how far it gets?

Comment 3

[Mark Banner (:standard8)]

Attachment: Log of test_update.js in Thunderbird

Here's the log - it has some extra debug prints, but hopefully that gives a bit more explanation as to what is happening.

Comment 4

[Dave Townsend [:mossop]]

This is probably because Thunderbird doesn't have lightweight theme updates enabled by setting lightweightThemes.update.enabled to true.

We can either enable it in the apps or I wouldn't mind forcing it on for the test's sake.

Comment 5

[[e-mail]]

This test hangs locally on my Linux SeaMonkey build too.

Services.prefs.setBoolPref("lightweightThemes.update.enabled", true");

prevents the hang. I need to update my build to see whether the test passes.

Comment 6

[Mark Banner (:standard8)]

Adding the pref locally worked, I've pushed that to the TB tree so that hopefully things green up a bit:

http://hg.mozilla.org/comm-central/rev/10b98b849f7c

Will re-assess tree state and tidy up this bug once I get off the plane in about 12 hours time.

Comment 7

[Justin Wood (:Callek)]

(In reply to comment #4)
> We can either enable it in the apps or I wouldn't mind forcing it on for the
> test's sake.

Since SeaMonkey at least does not have lightweight themes, I at least would appreciate forcing the expectation of the pref to on for the test.

Comment 8

[Mark Banner (:standard8)]

Attachment: Fix for apps/build configs that don't support lightweight themes

This adds setting the required pref to the test for applications/configurations which don't (yet?) support lightweight themes.

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/c5dde7d8d275

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Marking as verified fixed based on no failures in the last months.