Closed Bug 570068 Opened 14 years ago Closed 14 years ago

Fix parameter to setGrowlDelegate:

Categories

(Camino Graveyard :: General, defect)

Product:
Camino Graveyard
Component:
General
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

References

Details

Our Growl controller's dealloc calls setGrowlDelegate:@"". That seems weird, but it's recommended by Growl docs as the way to make Growl work if you don't have an actual delegate. However, sending something as an argument that is specified as implementing a protocol when the object doesn't implement it is a warning in 10.5.

We don't care if Growl still works after shutdown, so nil is fine. Also, it's never called anyway because Growl retains its delegate (!).
Landed http://hg.mozilla.org/camino/rev/eca0168f16de and on CVS trunk.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.