570083 - [k] Internal link hook throws parse error for invalid syntax

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P2)

Description

[Paul Craciunoiu [:paulc]]

STR:

1. Create a post with this content: [[Internal link|title|again]]

Expected:
Thread loads, showing a link, probably:
<a href="/kb/Internal+link|title">again</a>

Actual:
500 ISE.
  File "/data/www/support-stage-new.mozilla.com/kitsune/apps/sumo/utils.py", line 66, in hookInternalLink
    link, text = link.split('|')

ValueError: too many values to unpack


Should be easy to fix, likely just replace |.split('|')| with |.rsplit('|', 1)|

Comment 1

[James Socol [:jsocol, :james]]

(In reply to comment #0)
> Expected:
> Thread loads, showing a link, probably:
> <a href="/kb/Internal+link|title">again</a>

Expected in this case should be

    <a href="/kb/Internal+link">again|title</a>

i.e.: use lsplit instead of rsplit.

Comment 2

[James Socol [:jsocol, :james]]

(In reply to comment #1)
> i.e.: use lsplit instead of rsplit.

Actually, do we know how lsplit and rsplit will interact with RTL text? Is it possible to use split with a limit and have it follow the text direction?

Comment 3

[James Socol [:jsocol, :james]]

http://github.com/jsocol/kitsune/commit/5f7158ee67d

Pull requests sent for r?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; no tracebacks, and no 500 Internal Server Error.