570173 - Errors from findUpdates aren't passed out to the listener correctly

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

The error value should be passed in onUpdateFinished and we should still send all the other events in the case of an error.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Found a couple of things while writing the docs and this test. We weren't throwing the sensible error on http errors and when there was an error onNoCompatibilityUpdate was not getting sent. We also have the error code being passed on the wrong event in some cases.

I've also fixed bug 553869 here. It makes sense that the error codes from findUpdates should be defined on AddonManager even if they do match those on AddonUpdateChecker as that is what we use internally.

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 2

This one actually passes all tests. test_bug384052.js was a little broken, it should never find an update and should verify that there was an error (since the url it tries to use doesn't exist as we don't start the test server).

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 449320 [details] [diff] [review]
patch rev 2

Bah, still not quite right.

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 3

Ok final one. Forgot that we can't label the checkCert failure as a security error since then it wouldn't match all the other ssl related errors so might as well just lump them all as download errors.

Comment 5

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/9ec599d9a1f0

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marking as verified fixed based on check-in and a green tinderbox in our area.