Closed Bug 570173 Opened 11 years ago Closed 11 years ago
Errors from find
Updates aren't passed out to the listener correctly
The error value should be passed in onUpdateFinished and we should still send all the other events in the case of an error.
Found a couple of things while writing the docs and this test. We weren't throwing the sensible error on http errors and when there was an error onNoCompatibilityUpdate was not getting sent. We also have the error code being passed on the wrong event in some cases. I've also fixed bug 553869 here. It makes sense that the error codes from findUpdates should be defined on AddonManager even if they do match those on AddonUpdateChecker as that is what we use internally.
This one actually passes all tests. test_bug384052.js was a little broken, it should never find an update and should verify that there was an error (since the url it tries to use doesn't exist as we don't start the test server).
Comment on attachment 449320 [details] [diff] [review] patch rev 2 Bah, still not quite right.
Ok final one. Forgot that we can't label the checkCert failure as a security error since then it wouldn't match all the other ssl related errors so might as well just lump them all as download errors.
Attachment #449349 - Flags: review?(robert.bugzilla)
Attachment #449349 - Flags: review?(robert.bugzilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3
Marking as verified fixed based on check-in and a green tinderbox in our area.
Status: RESOLVED → VERIFIED
Target Milestone: mozilla1.9.3 → mozilla1.9.3a6
You need to log in before you can comment on or make changes to this bug.