570183 - End the base/basictypes.h insanity

Status: RESOLVED INVALID

(Core :: IPC, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Because of conflicting symbol definitions causing windows linking issues, we're forced to include this before prtypes.h in all MOZ_IPC code.  As IPC-enabled things spread across the code base, it's becoming harder and harder to get base/basictypes.h included first.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Force-include base/basictypes.h in MOZ_IPC-nebaled code so that we don't have to manually ensure it's included before prtypes.h

Was skeptical, but tryserver says this works.  \o/

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 449303 [details] [diff] [review]
Force-include base/basictypes.h in MOZ_IPC-nebaled code so that we don't have to manually ensure it's included before prtypes.h

That works, really? MSVC doesn't seem to use "-include" but rather "-FI"...

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 449303 [details] [diff] [review]
Force-include base/basictypes.h in MOZ_IPC-nebaled code so that we don't have to manually ensure it's included before prtypes.h

It works in the sense that it compiles on win32.  But in all the excitement I didn't push any changes that would have caused a failed build if the force-include was ignored, which it apparently was.  v2 will remove all |#include "base/basictypes.h"| from gecko.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Force-include base/basictypes.h in MOZ_IPC-nebaled code so that we don't have to manually ensure it's included before prtypes.h, v2

Removes all #include "base/basictypes.h" from gecko code and now builds on windows.  r?--> bsmedberg because bent is out for the week.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

bsmedberg tells me we can't force-include with all compilers we support to some degree.  Sigh.  (There's not a non-painful general solution that doesn't use force include.)