Closed
Bug 570332
Opened 14 years ago
Closed 14 years ago
nspr doesn't compile on mingw-w64
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.8.5
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
There are two problems with nspr on mingw for win64. The first is use of not portable __int64 in prtypes.h. The attached patch reuses previously typedefed PRInt64/PRUint64 instead of __int64. The other problem is in w96thread.c, where #if _MSC_VER <= 1200 guard is used that doesn't check if _MSC_VER is defined, so it tries to typedef DWORD_PTR to DWORD when _MSC_VER is not defined (and it's not defined on GCC). The attached patch fixes it.
Assignee | ||
Updated•14 years ago
|
Attachment #449465 -
Attachment is patch: true
Attachment #449465 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•14 years ago
|
Assignee: wtc → jacek
Comment 1•14 years ago
|
||
Comment on attachment 449465 [details] [diff] [review] fix v1.0 r=wtc. Thanks for the patch. I assume 'long' is still 32 bits on mingw-w64?
Attachment #449465 -
Flags: review?(ted.mielczarek) → review+
Comment 2•14 years ago
|
||
I checked in the patch on the NSPR trunk (NSPR 4.8.5). Checking in pr/include/prtypes.h; /cvsroot/mozilla/nsprpub/pr/include/prtypes.h,v <-- prtypes.h new revision: 3.43; previous revision: 3.42 done Checking in pr/src/md/windows/w95thred.c; /cvsroot/mozilla/nsprpub/pr/src/md/windows/w95thred.c,v <-- w95thred.c new revision: 3.19; previous revision: 3.18 done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.8.5
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #1) > (From update of attachment 449465 [details] [diff] [review]) > r=wtc. Thanks for the patch. > > I assume 'long' is still 32 bits on mingw-w64? Yes, it is. Thanks for review and check in.
You need to log in
before you can comment on or make changes to this bug.
Description
•