570332 - nspr doesn't compile on mingw-w64

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

There are two problems with nspr on mingw for win64. The first is use of not portable __int64 in prtypes.h. The attached patch reuses previously typedefed PRInt64/PRUint64 instead of __int64.

The other problem is in w96thread.c, where
#if _MSC_VER <= 1200
guard is used that doesn't check if _MSC_VER is defined, so it tries to typedef DWORD_PTR to DWORD when _MSC_VER is not defined (and it's not defined on GCC). The attached patch fixes it.

Comment 1

[Wan-Teh Chang]

Comment on attachment 449465 [details] [diff] [review]
fix v1.0

r=wtc.  Thanks for the patch.

I assume 'long' is still 32 bits on mingw-w64?

Comment 2

[Wan-Teh Chang]

I checked in the patch on the NSPR trunk (NSPR 4.8.5).

Checking in pr/include/prtypes.h;
/cvsroot/mozilla/nsprpub/pr/include/prtypes.h,v  <--  prtypes.h
new revision: 3.43; previous revision: 3.42
done
Checking in pr/src/md/windows/w95thred.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/w95thred.c,v  <--  w95thred.c
new revision: 3.19; previous revision: 3.18
done

Comment 3

[Jacek Caban]

(In reply to comment #1)
> (From update of attachment 449465 [details] [diff] [review])
> r=wtc.  Thanks for the patch.
> 
> I assume 'long' is still 32 bits on mingw-w64?

Yes, it is. Thanks for review and check in.