All content iterators need to take part in cycle collection

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Core
DOM
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla1.9.3a5
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(status1.9.2 .9-fixed, status1.9.1 .12-fixed)

Details

Attachments

(1 attachment)

Bug 569504 made nsContentIterator participate in cycle collection.  We need to do the same for nsPreContentIterator and nsSubtreeContentIterator as well.

Given that nsPreContentIterator only exists to set mPre to true, I decided to remove that class and make NS_NewPreContentIterator set mPre to true instead.

I also filed bug 570416 to create a static analysis script which detects other similar cases.
We also need this for branches.
status1.9.1: --- → ?
status1.9.2: --- → ?
Created attachment 449544 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #449544 - Flags: review?(jst)

Updated

7 years ago
Attachment #449544 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/961e152b8b7b
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Comment on attachment 449544 [details] [diff] [review]
Patch (v1)

This is the continuation of the work in bug 569504.
Attachment #449544 - Flags: approval1.9.2.5?
Attachment #449544 - Flags: approval1.9.1.11?

Comment 5

7 years ago
Comment on attachment 449544 [details] [diff] [review]
Patch (v1)

We will not be taking this for 3.6.6. Moving approval request forward.

If you disagree, send me an email.
Attachment #449544 - Flags: approval1.9.2.7?
Attachment #449544 - Flags: approval1.9.2.6-
Attachment #449544 - Flags: approval1.9.2.5?
Attachment #449544 - Flags: approval1.9.1.12?
Attachment #449544 - Flags: approval1.9.1.11?

Updated

7 years ago
status1.9.1: ? → ---
status1.9.2: ? → ---

Comment 6

7 years ago
Comment on attachment 449544 [details] [diff] [review]
Patch (v1)

a=LegNeato for 1.9.2.9 and 1.9.1.12
Attachment #449544 - Flags: approval1.9.2.9?
Attachment #449544 - Flags: approval1.9.2.9+
Attachment #449544 - Flags: approval1.9.1.12?
Attachment #449544 - Flags: approval1.9.1.12+
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f5ebe00ac30b
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2698ba315614
status1.9.1: --- → .12-fixed
status1.9.2: --- → .9-fixed
You need to log in before you can comment on or make changes to this bug.