570464 - CalDAV Cached Calendar never completes sync / Deleting Metadata fails

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

With the experimental cache enabled, deleting metadata fails with an error message. The fix is quite simple.

Also we have numerous astonishing bugs in the caldav code which were never noticed. This patch fixes, and blocks 1.0b2.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

The promised patch

Comment 2

[Simon Vaillancourt]

Comment on attachment 449596 [details] [diff] [review]
Fix - v1

r=simon but I think the notifyGetFailed call in "if (!this._reader) { }" in onStopRequest should be removed because if the reader is null it means that onStartRequest has already notified the caller of the failure (before setting _reader to null).

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c3c30b85849e>
-> FIXED

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/1ee9e14fac7b>
-> FIXED

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/a300b5de20be>
-> FIXED

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

the latter comm-1.9.2 push was the 20100525 relbranch push. I took out the notifyGetFailed as noted in comment 2, and also fixed another 1-line bug in the storage calendar, where relations were not being deleted. dbo approved this chunk.