Closed Bug 570467 Opened 10 years ago Closed 10 years ago

Default drag feedback doesn't appear anymore in many cases

Categories

(Core :: DOM: Drag & Drop, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5
Tracking Status
blocking2.0 --- final+

People

(Reporter: dao, Assigned: tnikkel)

References

Details

(Keywords: regression)

Attachments

(1 file)

For instance, links or images don't get the feedback, selected text however does. I noticed this today, probably regressed only a few days ago.
There seem to be no June 6 mac nightlies, so the best range I get here is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b219912edfec&tochange=5b3604a3cfbe

Bug 563878 is a plausible reason this might have broken....
Attached patch patchSplinter Review
The clip region we pass to PresShell::RenderNode in nsBaseDragService::DrawDrag was changed to be a stack variable from a pointer. So we end up passing an empty region in all the cases we used to pass null.
Assignee: nobody → tnikkel
Attachment #449746 - Flags: review?(matspal)
Comment on attachment 449746 [details] [diff] [review]
patch

r=mats
Attachment #449746 - Flags: review?(matspal) → review+
http://hg.mozilla.org/mozilla-central/rev/12ea060fa735
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Summary: Default drag feedback doesn't appear anymore in may cases → Default drag feedback doesn't appear anymore in many cases
blocking2.0: ? → final+
You need to log in before you can comment on or make changes to this bug.