570467 - Default drag feedback doesn't appear anymore in many cases

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Dão Gottwald [:dao]]

For instance, links or images don't get the feedback, selected text however does. I noticed this today, probably regressed only a few days ago.

Comment 1

[Boris Zbarsky [:bzbarsky]]

There seem to be no June 6 mac nightlies, so the best range I get here is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b219912edfec&tochange=5b3604a3cfbe

Bug 563878 is a plausible reason this might have broken....

Comment 2

[Timothy Nikkel (:tnikkel)]

Yeah, caused by part 1b (http://hg.mozilla.org/mozilla-central/rev/d5ca465f4238) of bug 563878.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: patch

The clip region we pass to PresShell::RenderNode in nsBaseDragService::DrawDrag was changed to be a stack variable from a pointer. So we end up passing an empty region in all the cases we used to pass null.

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 449746 [details] [diff] [review]
patch

r=mats

Comment 5

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/12ea060fa735