570551 - Don't use shared-permanent properties to implement RegExp instance properties

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 449685 [details] [diff] [review]
Patch

RegExpClass needs an enumerate hook to go with that resolve hook.

The easiest way to do it would be to make that static data file-scope rather than function-scope ...which maybe isn't so bad anyway.

Comment 2

[Jeff Walden [:Waldo]]

It isn't currently the case that resolve hooks require corresponding enumerate hooks.  From documentation for JSEnumerateOp:

"[The hook] should define any remaining lazy properties *that should be enumerable* but are not yet defined in obj."

https://developer.mozilla.org/en/SpiderMonkey/JSAPI_Reference/JSEnumerateOp

(Emphasis added.)

I have heard rumblings of changing this to require enumerate hooks to also add non-enumerable resolved properties, but it hasn't happened yet.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 449685 [details] [diff] [review]
Patch

Note as prior art that fun_resolve does not have a corresponding fun_enumerate.

Comment 4

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/60af001940cf

Comment 5

[Brendan Eich [:brendan]]

Waldo is right that enumerate is thus far for enumerable props, since JSOP_IN and hasOwnProperty both resolve, so find non-enumerable lazy props

/be

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/60af001940cf