Closed Bug 570566 Opened 14 years ago Closed 14 years ago

Crash [@ nsTextControlFrame::SetInitialChildList] removing type from <input type=image>

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5
Tracking Status
blocking2.0 --- final+

People

(Reporter: jruderman, Assigned: ehsan.akhgari)

References

Details

(4 keywords)

Crash Data

Attachments

(3 files)

###!!! ASSERTION: Single line text controls need to have a state associated with them: 'mInputData.mState', file content/html/content/src/nsHTMLInputElement.cpp, line 581

Crash [@ nsTextControlFrame::SetInitialChildList]

I'm guessing this is a regression from bug 534785.
blocking2.0: --- → ?
Attached patch Patch (v1)Splinter Review
The problem was that I did not initialize mInputData.mState when the type attribute was removed.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #450014 - Flags: review?(jst)
Comment on attachment 450014 [details] [diff] [review]
Patch (v1)

- In content/html/content/crashtests/570566-1.html:

+<body onload="document.getElementById('i').removeAttribute('type')"><input id=i type=image></body>
\ No newline at end of file

Add a newline at end of file?

r=jst
Attachment #450014 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/e7993ce9d265
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
blocking2.0: ? → final+
Crash Signature: [@ nsTextControlFrame::SetInitialChildList]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: