Closed Bug 570588 Opened 10 years ago Closed 10 years ago

Move current versions of remote browser bindings and remote content script to mobile-browser

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This is a basic patch that moves the source files of:
chrome/content/bindings/browser.js
chrome/content/bindings/browser.xul
chrome/content/frame-content.js -> content.js

to mobile-browser repo. Also adds the files to chrome/jar.mn

However, it does not activate <browser remote="true"> yet. This patch is only step one. The next patches will activate the new browser binding. The patch does not load the remote script (content.js) either. Future patches will do that.
Attachment #449727 - Flags: review?(mbrubeck)
Attachment #449727 - Flags: review?(mbrubeck) → review+
I think this patch collapse with the one into bug 566640 which already add browser.xml/browser.js was done into mobile-browser. 
It does not add frame-content.js mostly because this is not require yet but my plan was to move it to mobile-browser once Forms.js will be isolated and easily backport from the e10s repo to mobile-browser.
(In reply to comment #1)
> I think this patch collapse with the one into bug 566640 which already add
> browser.xml/browser.js was done into mobile-browser. 
> It does not add frame-content.js mostly because this is not require yet but my
> plan was to move it to mobile-browser once Forms.js will be isolated and easily
> backport from the e10s repo to mobile-browser.

Vivien - Yeah, I started trying to land the browser.xml patch in bug 566640, but it was bit-rotted. I decided to just start fresh with current versions of the files.

I want to rebase your other patch (the main patch) in bug 566640 with _this_ patch. Also, rebase the DOM/Message API patch in bug 568092 against this patch too.
pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/2637487e9046
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.