570603 - Autocomplete should search while composing on Android

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Michael Wu [:mwu]]

Attachment: Autocomplete on text events

autocomplete.xml currently doesn't handle the text event, so no searches are performed while the user is using an IME to input text.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 449734 [details] [diff] [review]
Autocomplete on text events

Somehow this manages to break the normal case..

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is not a bug, see bug 165055.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

screenshots on Safari.
http://www.d-toybox.com/studio/weblog/show.php?mode=single;id=2009030700

If we open the autocomplete candidate window, we have very big a11y problem.

Comment 4

[Michael Wu [:mwu]]

This is a serious problem on mobile (in particular, Android). We don't have control over whether the softkb gives us autocomplete. The location bar will not complete properly until the compose is completed, which is bad. If this fix will have to be mobile/android only, that's fine.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Autocomplete during composition (mobile only) v2

mwu:

I basically moved your patch to mobile-browser. Mobile-browser has a binding for autocomplete that inherits from toolkit.

Seems to work well on Android, but I don't know how to test on Maemo (we can also just make this Android-only).

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 459149 [details] [diff] [review]
Autocomplete during composition (mobile only) v2

If it works ok on desktop it should be fine on Maemo.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 459149 [details] [diff] [review]
Autocomplete during composition (mobile only) v2

Tested on desktop with ibus-py IME

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Why move this to mobile only? Is it because of the accessibility issue Masayuki points out?

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Right. It's desirable on mobile but not desirable on desktop. On a desktop the autocomplete popup might cover up anything that the IME displays. On mobile, (Android at least) we make room for the IME display so it's not a problem.

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

mfinkle: Can you land this? Thanks!

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/382f1d7d5999

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Backing out this patch. It seems to have broken autocomplete on Android

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

backout:
http://hg.mozilla.org/mobile-browser/rev/b9aa0d779d6e

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Ready to be pushed again since bug 576065 landed.

Comment 15

[Matt Brubeck (:mbrubeck)]

pushed again: http://hg.mozilla.org/mobile-browser/rev/dbfee3e7fa90