570803 - ExecMgr implementation (not interface) should define available run modes

Status: VERIFIED WONTFIX

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Edwin Smith]

From https://bugzilla.mozilla.org/show_bug.cgi?id=563119#c11

Simon wrote:

Currently Runmode is a global enum referenced in AvmCore, Config, exec-jit and
ShellCoreSettings (and hardcoded into the commandline args). I'd say this
implies that all the Runmodes are applicable to all ExecMgrs. For RM_jit_all
and RM_interp_all this should be the case, and should produce the expected
behavior. But 'RM_mixed' may be insufficient to describe everything other
ExecMgrs offer. For BaseExecMgr it means 'interpret functions/methods we
identify at load-time as being run once, and jit everything else'. For other
ExecMgrs will it just mean 'use the mechanism/policy that isn't RM_interp_all
or RM_jit_all'?

So it's a bit of a hand-wavy suggestion, but I think the ExecMgr implementing
class should define the available modes. Maybe RM_mixed can then be renamed to
its truer semantics of 'RM_execmgr_default'.

Comment 1

[Trevor Baker]

bulk verifying resolved !fixed issues