570812 - remove xpinstall from mobile specific browser-chrome tests package files

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

xpinstall adds some browser-chrome tests that interfere with mobile:

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/Makefile.in#51

Comment 1

[Justin Wood (:Callek)]

Mark,

Do we want _all_ xpinstall tests here blocked for mobile; or _only_ a subset. I ask based on your "some browser-chrome".

Comment 2

[Chris Cooper [:coop] (he/him)]

Is there anything here for RelEng to do, or is this strictly a test packaging issue?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this is strictly a test packaging issue, a makefile fix.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Mark,
> 
> Do we want _all_ xpinstall tests here blocked for mobile; or _only_ a subset. I
> ask based on your "some browser-chrome".

Remove all from Fennec. We can duplicate any tests that would work for Fennec.

Comment 5

[Justin Wood (:Callek)]

Attachment: just do it

<jmaher> Callek: we will need to remove all the xpinstall tests from the 'mobile' build scenario
<mfinkle> Callek: all!

Comment 6

[Justin Wood (:Callek)]

Attachment: just do it (with right patch this time)

Comment 7

[Justin Wood (:Callek)]

Attachment: third times the charm

:/

Comment 8

[Justin Wood (:Callek)]

Attachment: if I have to attach a fifth time I forfeit my commit privs

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 451806 [details] [diff] [review]
if I have to attach a fifth time I forfeit my commit privs

this passes on my local build and really does remove the tests.  

After this lands, we will have all non fennec tests in the mochitest browser-chrome package-tests for Fennec!

Comment 10

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-central/rev/c1ac92989e91