Closed Bug 570812 Opened 14 years ago Closed 14 years ago

remove xpinstall from mobile specific browser-chrome tests package files

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: Callek)

References

Details

(Whiteboard: [unittest][mobile])

Attachments

(1 file, 3 obsolete files)

if I have to attach a fifth time I forfeit my commit privs
534 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review 
xpinstall adds some browser-chrome tests that interfere with mobile:

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/Makefile.in#51
Blocks: 535922
Mark,

Do we want _all_ xpinstall tests here blocked for mobile; or _only_ a subset. I ask based on your "some browser-chrome".
Is there anything here for RelEng to do, or is this strictly a test packaging issue?
Whiteboard: [unittest][mobile]
this is strictly a test packaging issue, a makefile fix.
Component: Release Engineering → General
Product: mozilla.org → Testing
QA Contact: release → general
Version: other → Trunk
(In reply to comment #1)
> Mark,
> 
> Do we want _all_ xpinstall tests here blocked for mobile; or _only_ a subset. I
> ask based on your "some browser-chrome".

Remove all from Fennec. We can duplicate any tests that would work for Fennec.
Attached patch just do it (obsolete) — — Splinter Review 
<jmaher> Callek: we will need to remove all the xpinstall tests from the 'mobile' build scenario
<mfinkle> Callek: all!
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #451800 - Flags: review?(jmaher)

        Attachment #451800 -
        Attachment is obsolete: true

        Attachment #451801 -
        Flags: review?(jmaher)

        Attachment #451800 -
        Flags: review?(jmaher)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        third times the charm (obsolete)
        — 
          — Splinter Review
      

    


  
:/

        Attachment #451801 -
        Attachment is obsolete: true

        Attachment #451804 -
        Flags: review?(jmaher)

        Attachment #451801 -
        Flags: review?(jmaher)

    
    

    
  


  

        Attachment #451804 -
        Attachment is obsolete: true

        Attachment #451806 -
        Flags: review?(jmaher)

        Attachment #451804 -
        Flags: review?(jmaher)

    
  

        Attachment #451806 -
        Attachment description: if I have to atatch a fifth time I forfeit my commit privs → if I have to attach a fifth time I forfeit my commit privs

        Attachment #451806 -
        Attachment is patch: true

        Attachment #451806 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  
Comment on attachment 451806 [details] [diff] [review]
if I have to attach a fifth time I forfeit my commit privs

this passes on my local build and really does remove the tests.  

After this lands, we will have all non fennec tests in the mochitest browser-chrome package-tests for Fennec!

        Attachment #451806 -
        Flags: review?(jmaher) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c1ac92989e91
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: