570896 - add support for different background-origin and background-clip in background shorthand (css3-background)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The latest editor's draft of css3-background adds the ability to specify background-clip and background-origin differently.  When this reaches CR (the current public draft is a CR, but it's not in that), we should implement it, and adjust various tests.

This requires code changes in two places: nsCSSParser::ParseBackgroundItem for parsing and nsCSSDeclaration::GetValue for the getter/serialization case, plus adjusting all the relevant tests (which there should be a bunch of).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Allow separate background-origin and background-clip to be set in the background shorthand.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 721472 [details] [diff] [review]
Allow separate background-origin and background-clip to be set in the background shorthand.

>+isnot(e.style.background, "", "should have background shorthand (origin:content-box)");

Can you make that into an is() test with the right value?

r=me

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Boris Zbarsky (:bz) from comment #2)
> >+isnot(e.style.background, "", "should have background shorthand (origin:content-box)");
> 
> Can you make that into an is() test with the right value?

I'd prefer not to, since there isn't really a single right value; I think things are covered well enough by the property_database.js-based tests.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

is comment 3 ok with you?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2aaba07995ed


For documentation, the spec is http://dev.w3.org/csswg/css3-background/#background ; we previously didn't support the bit about allowing 2 <box> values (we only supported 1); now we do.  The key part of the spec is:

  If one <box> value is present then it sets both ‘background-origin’
  and ‘background-clip’ to that value. If two values are present, then
  the first sets ‘background-origin’ and the second ‘background-clip’.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2aaba07995ed

Comment 7

[Boris Zbarsky [:bzbarsky]]

> is comment 3 ok with you?

Yes.

Comment 8

[Jean-Yves Perrier [:teoli]]

Doc updated:
https://developer.mozilla.org/en-US/docs/Web/CSS/background
and
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/22