57094 - xpidl-generated headers shouldn't need NS_NO_VTABLE

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Mike McCabe]

Pavlov is working with some small IDL files that don't include nsISupports.idl;
nsISupportsUtils.idl.  This currently busts because header output assumes that
NS_NO_VTABLE is defined (it's used to enable an optimization on Windows).  We
can easily add an #ifndef define of NS_NO_VTABLE to avoid this problem.  Diff to
follow.

Comment 1

[Mike McCabe]

Attachment: emit #ifndef NS_NO_VTABLE define of NS_NO_VTABLE

Comment 2

[Mike McCabe]

Attachment: add a note about what's going on

Comment 3

[John Bandhauer]

sr=jband

Comment 4

[Mike McCabe]

Fix checked in.  (After a few fireworks; turns out we also needed to #undef
NS_NO_VTABLE in nsISupportsUtils.h in the case when it was already defined by
the xpidl-generated header.)