Closed
Bug 570949
Opened 14 years ago
Closed 14 years ago
Patch from bug 566247 broke mingw compilation.
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b1
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(2 files)
|
578 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
|
471 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The patch tries to find MASM on mingw, because the check for mingw is wrong: "$GNU_CC" != "yes". GNU_CC has no value or 1, never "yes". I've attached a patch that changes the test to check for GNU_CC being not empty, like other tests do.
|
Assignee | |
Updated•14 years ago
|
Attachment #450094 -
Attachment is patch: true
Attachment #450094 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
|
||
Comment 1•14 years ago
|
||
Comment on attachment 450094 [details] [diff] [review] fix v1.0 Must have been a mixup, my review said to use "-n $GNU_CC" (which is the opposite test, but at least the right syntax).
Attachment #450094 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
mingw-w64 build is also affected by mentioned bug. It wrongly uses MSVC win64 configuration.
Attachment #450325 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•14 years ago
|
Attachment #450325 -
Flags: review?(ted.mielczarek) → review+
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4886e4b9058e
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•