Closed Bug 570981 Opened 10 years ago Closed 10 years ago

Remove URLBarSetURI's aValid parameter

Categories

(Firefox :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 4.0b1

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 562649 made this parameter superfluous by eliminating the case where aURI was passed before the location had changed (i.e. the page proxy state had to be "invalid").
Attachment #450135 - Flags: review?(mano)
Summary: Remove URLBarSetURI's aValid valid parameter → Remove URLBarSetURI's aValid parameter
(In reply to comment #0)
> by eliminating the case where aURI was passed before the location had changed

Can you elaborate? I don't understand how bug 562649 had that effect.
It removed the case where we passed aURI with aValid == false (implicitly, as the argument was omitted).
Comment on attachment 450135 [details] [diff] [review]
patch

Oh, I see. The isBlank change caused me to misread that logic.
Attachment #450135 - Flags: review?(mano) → review+
Blocks: SMtabAPI
http://hg.mozilla.org/mozilla-central/rev/4c811642b403
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a5
Target Milestone: Firefox 3.7a5 → Firefox 3.7a6
You need to log in before you can comment on or make changes to this bug.