570995 - Loading testcase from bug 522847 has terrible performance with NVDA running

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

The reason, according to Surkov on IRC is that we implemented group attributes for tables, and NVDA are asking for all group attributes on this big table. The calculation is o(n)2. Requesting blocking since this is a regression in 1.9.3.

Comment 1

[alexander :surkov (:asurkov)]

after the bug 575576 is fixed the bottle neck is nsTableOuterFrame::GetRowAndColumnByIndex

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

After discussion with Marco, we decided this wouldn't block a release. The work on dependency bugs has made this test case endurable. If we get a patch for the GetRowAndColumnByIndex work we can decide to take that later.

Comment 3

[alexander :surkov (:asurkov)]

we should considered to fix it for fx5

Comment 4

[Hubert Figuiere [:hub]]

It still occur on 7.0.1. Loading the test case cause Firefox to "Not respond"

Comment 5

[Marco Zehe (:MarcoZ)]

Performance with this testcase has got much better. Initial load takes a while because this is a lot of data, but actually rearranging the nodes (like hitting Run Test without changing any of the default parameters) only takes around 1950 MS now. Some longer delay in the updates, but nothing near as bad as it used to be. Alex, do you want to run another profiling session on this to see if we still have an obvious bottleneck somewhere?

Comment 6

[alexander :surkov (:asurkov)]

I'll take a look before closing the bug.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Jamie, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[James Teh [:Jamie]]

Seems to load pretty quickly now with NVDA.