571175 - WebGLContextGL.cpp:878: warning: comparison between signed and unsigned integer expressions

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Daniel Holbert [:dholbert]]

When building mozilla-central:
{
> content/canvas/src/WebGLContextGL.cpp: In member function ‘virtual nsresult mozilla::WebGLContext::DrawElements(WebGLenum, WebGLsizei, WebGLenum, WebGLint)’:
> content/canvas/src/WebGLContextGL.cpp:878: warning: comparison between signed and unsigned integer expressions
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: cast byteOffset to be unsigned

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 450301 [details] [diff] [review]
fix: cast byteOffset to be unsigned

Note that if byteOffset were negative, we would have returned already. (there's a check for that at the beginning of this method)  So it's safe to cast to be unsigned.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hah, sorry, I fixed this locally (and I thought "man, dholbert's going to kill me")... I've got it as part of another patch, mind just letting me land that?  Should be tomorrow.

Comment 4

[Daniel Holbert [:dholbert]]

sure. :)

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fixed as part of:

http://hg.mozilla.org/mozilla-central/rev/7b15545cf9aa