Closed
Bug 571184
Opened 14 years ago
Closed 14 years ago
remove nsIAccessNode traversal methods
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
90.62 KB,
patch
|
davidb
:
review+
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
1) Remove nsIAccessNode traversal methods 2) Cache nsIAccessible objects 3) Remove unnecessary query interfaces from nsIAcessNode while we're getting accessible object from the cache 4) Change return values of Init() and Shutdown() 5) It shouldn't affect on ISimpleDOMNode since it doesn't use the cache to get accessnode object if there's no accessible object
Attachment #450315 -
Flags: review?(marco.zehe)
Attachment #450315 -
Flags: review?(bolterbugz)
Assignee | ||
Comment 1•14 years ago
|
||
6) virtual void Init() in mac/nsDocAccessibeWrap.h is fixed locally 7) test_invalidate_accessnode.html is removed since there's nothing to test here any more because the root problem of bug 434464 (this test was introduced for) has gone
Assignee | ||
Comment 2•14 years ago
|
||
try server build (will be soon) https://build.mozilla.org/tryserver-builds/surkov.alexander@gmail.com-try-16ddad2671b8/. Marco, it's necessary to test with JAWS.
Comment 3•14 years ago
|
||
Comment on attachment 450315 [details] [diff] [review] patch r=me; but I don't understand why we cached nsAccessNodes before, instead of accessible objects. Was it for performance for ISimpleDOM-only tools? >- accessible = do_QueryObject(GetCachedAccessNode(aNode)); >+ accessible = GetCachedAccessible(aNode); Nice :) >diff --git a/accessible/src/mac/nsAccessibleWrap.mm b/accessible/src/mac/nsAccessibleWrap.mm >+PRBool > nsAccessibleWrap::Init () > if (!mNativeWrapper && !AncestorIsFlat()) { > // Create our native object using the class type specified in GetNativeType(). > mNativeWrapper = new AccessibleWrapper (this, GetNativeType()); > } I noticed you added a bail here for nsDocAccessibleWrap::Init... why there and not here? When does it bite?
Attachment #450315 -
Flags: review?(bolterbugz) → review+
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3) > (From update of attachment 450315 [details] [diff] [review]) > r=me; but I don't understand why we cached nsAccessNodes before, instead of > accessible objects. Was it for performance for ISimpleDOM-only tools? Is it general question? If so I don't know. If you ask how does the patch affects on them then nohow. > > mNativeWrapper = new AccessibleWrapper (this, GetNativeType()); > > } > > I noticed you added a bail here for nsDocAccessibleWrap::Init... why there and > not here? When does it bite? It should be here as well.
Assignee | ||
Comment 5•14 years ago
|
||
http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/surkov.alexander@gmail.com-16ddad2671b8/
Comment 6•14 years ago
|
||
Comment on attachment 450315 [details] [diff] [review] patch This works with JAWS except the same problems as in bug 541618 current try-server build. But no netative effect on pages that do work like www.blindcooltech.com.
Attachment #450315 -
Flags: review?(marco.zehe) → review+
Comment 7•14 years ago
|
||
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 450315 [details] [diff] [review] [details]) > > r=me; but I don't understand why we cached nsAccessNodes before, instead of > > accessible objects. Was it for performance for ISimpleDOM-only tools? > > Is it general question? If so I don't know. If you ask how does the patch > affects on them then nohow. General question. > > > > mNativeWrapper = new AccessibleWrapper (this, GetNativeType()); > > > } > > > > I noticed you added a bail here for nsDocAccessibleWrap::Init... why there and > > not here? When does it bite? > > It should be here as well. OK thanks.
Assignee | ||
Comment 8•14 years ago
|
||
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/6768f98d8cea
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•