Closed Bug 571199 Opened 10 years ago Closed 10 years ago

Run verify_l10n.sh per platform

Categories

(Release Engineering :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [automation])

Attachments

(3 files, 4 obsolete files)

l10n verification may be split and run for each platform separately after landing the tools patch in Bug 559057. This will speed up the release automation and will reduce required disk space.
Attached patch tools changesSplinter Review
Attachment #451009 - Flags: review?(nrthomas)
Attached patch buildbot-configs changes (obsolete) — Splinter Review
Attachment #451010 - Flags: review?(nrthomas)
Attached patch buildbotcustom changes (obsolete) — Splinter Review
> +                  '%s:/home/ftp/pub/%s/nightly/%s-candidates/build%s/%s' %

Absence of trailing slash will create the same directory hierarchy as before, but for the current platform only.
Attachment #451011 - Flags: review?(nrthomas)
Attached patch buildbot-configs changes (obsolete) — Splinter Review
Added missing schedulers.
Attachment #451010 - Attachment is obsolete: true
Attachment #451012 - Flags: review?(nrthomas)
Attachment #451010 - Flags: review?(nrthomas)
I just tested the patches in staging. win32, macosx and linux passed the test. 

* Metadiffs created for all platforms are the same (http://pastebin.mozilla.org/736115)

* Disk usage:
2.7G	macosx_l10n_verification/
1.2G	win32_l10n_verification/
1.4G	linux_l10n_verification/

Looks like we may reduce buildSpace from 14G to 5G.
Priority: P5 → P2
Attachment #451009 - Flags: review?(nrthomas) → review+
Comment on attachment 451011 [details] [diff] [review]
buildbotcustom changes

>diff --git a/process/factory.py b/process/factory.py
> class L10nVerifyFactory(ReleaseFactory):
>     def __init__(self, cvsroot, stagingServer, productName, version,
>                  buildNumber, oldVersion, oldBuildNumber,
>-                 l10nPlatforms, verifyDir='verify', linuxExtension='bz2',
>+                 platform, verifyDir='verify', linuxExtension='bz2',
>                  buildSpace=14, **kwargs):

Go ahead and reduce the buildSpace to 4, and CC some T'bird, SeaMonkey and Calendar folks so they know how to make matching changes to their release_master.py's.
Attachment #451011 - Flags: review?(nrthomas) → review+
Comment on attachment 451012 [details] [diff] [review]
buildbot-configs changes

>diff --git a/mozilla2/release_master.py b/mozilla2/release_master.py
>+    builders.append({
>+        'name': '%s_l10n_verification' % platform,
>+        'slavenames': branchConfig['platforms']['macosx']['slaves'],
>+        'category': 'release',
>+        'builddir': '%s_l10n_verification' % platform,
>+        'factory': l10n_verification_factory,
>+        'nextSlave': _nextFastSlave,
>+    })

If this ends up gobbling up fast mac slaves then we can come back later and switch it run on the native platforms.
Attachment #451012 - Flags: review?(nrthomas) → review+
(In reply to comment #7)
> If this ends up gobbling up fast mac slaves then we can come back later and
> switch it run on the native platforms.

+1. The only thing which is my mind, we have to have 7z.exe on win32 slaves in PATH.

> >+                 platform, verifyDir='verify', linuxExtension='bz2',
> >                  buildSpace=14, **kwargs):
> 
> Go ahead and reduce the buildSpace to 4, and CC some T'bird, SeaMonkey and
> Calendar folks so they know how to make matching changes to their
> release_master.py's.

I'll fix tb, sm, calendar configs.

CCing Calendar, Thunderbird and Seamonkey people.
One liner:
-                 buildSpace=14, **kwargs):
+                 buildSpace=4, **kwargs):

Keeping r+.
Attachment #451011 - Attachment is obsolete: true
Attachment #451988 - Flags: review+
Attached patch buildbot-configs changes (obsolete) — Splinter Review
The same changes applied to seamonkey, calendar and thunderbird directories.

Nick, could you review this version (interdiff is here: http://diff.pastebin.mozilla.org/736775)?

1. L10nVerifyFactory requires platform instead of l10nPlatforms
2. 'l10n_verification' -> '%s_l10n_verification' % platform
Attachment #451012 - Attachment is obsolete: true
Attachment #451997 - Flags: review?(nrthomas)
Comment on attachment 451997 [details] [diff] [review]
buildbot-configs changes

r=philipp for the calendar part of this patch.
Attachment #451997 - Flags: review+
Comment on attachment 451997 [details] [diff] [review]
buildbot-configs changes

Forwarding r+ on the Firefox parts. Setting r? for SeaMonkey and Thunderbird
Attachment #451997 - Flags: review?(nrthomas)
Attachment #451997 - Flags: review?(kairo)
Attachment #451997 - Flags: review?(gozer)
Attachment #451997 - Flags: review+
Attachment #451997 - Flags: review?(kairo) → review+
Attachment #451997 - Flags: review?(gozer) → review+
Attachment #451997 - Flags: checked-in?
Refreshed bitrotten patch. Keeping r+.
Attachment #451997 - Attachment is obsolete: true
Attachment #455115 - Flags: review+
Attachment #451997 - Flags: checked-in?
Tested during 3.6.7 build1 and 3.5.11 build1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
The matching clobberer change got done in bug 584620.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.