Closed Bug 571618 Opened 9 years ago Closed 9 years ago

"ASSERTION: should only care when we have an outside bullet"

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached image testcase
###!!! ASSERTION: should only care when we have an outside bullet: '(GetStyleDisplay()->mDisplay == NS_STYLE_DISPLAY_LIST_ITEM || (GetStyleContext()->GetPseudo() == nsCSSAnonBoxes::scrolledContent && GetParent()->GetStyleDisplay()->mDisplay == NS_STYLE_DISPLAY_LIST_ITEM)) && HaveOutsideBullet()', file layout/generic/nsBlockFrame.cpp, line 6422

Regression from bug 571281?
Yes, I forgot to update the assert to match the code...
Blocks: 571281
Hmm.  So this is not that hard to fix, but should foreignObjects with this display value really get bullets?  With the fix for bug 571281, they do.
Attached patch Like soSplinter Review
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #450811 - Flags: review?(roc)
Pushed http://hg.mozilla.org/mozilla-central/rev/09f4f1283319
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.