Search UI should follow a grid design

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
User Interface
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Guy Pyrzak, Assigned: Guy Pyrzak)

Tracking

unspecified
Bugzilla 4.0
Bug Flags:
approval +
approval4.0 +
blocking4.0 +

Details

Attachments

(1 attachment, 3 obsolete attachments)

v4
4.05 KB, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
The new search UI doesn't follow a grid design and some of the labels are too close to the elements they represent. The CSS should be updated to make the UI follow a grid and therefore be easier to follow and look more organized.
(Assignee)

Updated

8 years ago
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.8
(Assignee)

Comment 1

8 years ago
Created attachment 450801 [details] [diff] [review]
V1
Assignee: ui → guy.pyrzak
Attachment #450801 - Flags: review?(mkanat)
(Assignee)

Updated

8 years ago
Depends on: 450301

Comment 2

8 years ago
Comment on attachment 450801 [details] [diff] [review]
V1

Cool, I really like how the Summary search box looks now! :-) However, I'd like it even more if it could be centered relative to the 3/4 boxes below it.

I don't like the way the text-search boxes look in the Detailed Bug Information section. I much much prefer them to be single lines. I just want those single lines to line up with each other properly.
Attachment #450801 - Flags: review?(mkanat) → review-

Updated

7 years ago
Flags: blocking4.0+

Comment 3

7 years ago
Ping. :-)
(Assignee)

Comment 4

7 years ago
Created attachment 465893 [details] [diff] [review]
v2

couldn't get the summary fix you wanted but did the other stuff.
Attachment #450801 - Attachment is obsolete: true
Attachment #465893 - Flags: review?(mkanat)

Comment 5

7 years ago
Comment on attachment 465893 [details] [diff] [review]
v2

The Deadline field looks weird now in Detailed Bug Information.
Attachment #465893 - Flags: review?(mkanat) → review-

Comment 6

7 years ago
Oh, also, you may want to right-align the summary field label.
(Assignee)

Comment 7

7 years ago
Created attachment 466043 [details] [diff] [review]
V3
Attachment #465893 - Attachment is obsolete: true
Attachment #466043 - Flags: review?(mkanat)

Updated

7 years ago
Attachment #466043 - Attachment is patch: true
Attachment #466043 - Attachment mime type: application/octet-stream → text/plain

Comment 8

7 years ago
Comment on attachment 466043 [details] [diff] [review]
V3

The second Deadline box is still on a separate line, for me. Also, at least in Chrome, there's a slightly odd gap between the labels of the text fields and the drop-downs for the search-type selection. (I'm guessing that's from the margin-right: 2em" on the field_label span.)
Attachment #466043 - Flags: review?(mkanat) → review-
(Assignee)

Comment 9

7 years ago
Created attachment 467154 [details] [diff] [review]
v4
Attachment #466043 - Attachment is obsolete: true
Attachment #467154 - Flags: review?(mkanat)

Comment 10

7 years ago
Comment on attachment 467154 [details] [diff] [review]
v4

Looks faaaahbulous!! :-D
Attachment #467154 - Flags: review?(mkanat) → review+

Comment 11

7 years ago
You're my hero, pyrzak. :-)
Flags: approval4.0+
Flags: approval+

Comment 12

7 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified skins/standard/search_form.css
modified template/en/default/search/field.html.tmpl
modified template/en/default/search/form.html.tmpl
Committed revision 7450.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/
modified skins/standard/search_form.css
modified template/en/default/search/field.html.tmpl
modified template/en/default/search/form.html.tmpl
Committed revision 7386.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.