571817 - Invalid parameter passed to Bugzilla when Editing Groups on IIS

Status: RESOLVED DUPLICATE of bug 521416

(Bugzilla :: Administration, task)

Description

[Steve]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.1.9) Gecko/20100315 Firefox/3.5.9
Build Identifier: 3.6

Invalid parameter  passed to Bugzilla::Group::new_from_list: It must be numeric.

WIn 2k + IIS

Reproducible: Always

Steps to Reproduce:
1.create a group
2.goto edit the group
3.update
Actual Results:  
Invalid parameter  passed to Bugzilla::Group::new_from_list: It must be numeric.

Comment 1

[Steve]

Attachment: Small edit to fix the error when updating Groups

This should be ok for all DB types.

Comment 2

[Max Kanat-Alexander]

Comment on attachment 450984 [details] [diff] [review]
Small edit to fix the error when updating Groups

The code that I'm looking at already has this fix, in 3.6. Perhaps this bug is a dup?

Comment 3

[Frédéric Buclin]

Yeah, this code is not the one from 3.6, see bug 354627. This has been fixed in 3.2 already.

Comment 4

[Steve]

?? I'm using 3.6

http://www.bugzilla.org/download/#v36

Comment 5

[Steve]

Attachment: Corrected Diff

The BUG is still valid. I just had the diff the wrong way around.

Do people not test these bugs?

Comment 6

[Steve]

Comment on attachment 451107 [details] [diff] [review]
Corrected Diff

A Fixed Diff

Comment 7

[Frédéric Buclin]

Comment on attachment 451107 [details] [diff] [review]
Corrected Diff

This crashes Bugzilla when using Apache.

Comment 8

[Max Kanat-Alexander]

Okay, so there actually is some sort of bug--it seems to be a general problem with IIS passing us undef in situations where I don't understand why we get undef.

Comment 9

[Max Kanat-Alexander]

Steve: Could you get me the output of this following command on the page that you POST'ed to?

use Data::Dumper; die Dumper(scalar Bugzilla->cgi->Vars);

Comment 10

[Steve]

Attachment: Fix to Object.pm

On the chance new_from_list is passed a null element it should return a corrected array instead of raising an error.

Comment 11

[Steve]

Comment on attachment 451118 [details] [diff] [review]
Fix to Object.pm

skips any null elements

Comment 12

[Max Kanat-Alexander]

glob: Do you have any clue why IIS is passing us undef instead of an empty array for this situation?

Comment 13

[Steve]

It's not just this situation. There's other areas in Bugzilla where we get undef responses too.

Comment 14

[Frédéric Buclin]

(In reply to comment #13)
> It's not just this situation. There's other areas in Bugzilla where we get
> undef responses too.

Which is why your patch is only a workaround, not a real fix. Probably Bugzilla/CGI.pm needs to be fixed, in that case.

Comment 15

[Steve]

Here's the dump you asked for.

$VAR1 = {
          '' => undef,
          'icon_url' => '',
          'name' => 'Test',
          'group_id' => '16',
          'regexp' => '',
          'desc' => 'tester1',
          'isactive' => '1',
          'action' => 'postchanges',
          'token' => 'zVuthJK1kk'
        };

Comment 16

[Max Kanat-Alexander]

Should be fixed by the patch in bug 521416.