571842 - add classes to split menu for CSS addressability

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

Dao, would it be possible to add some more classes added to the new split menu for addressability in CSS? Something like:

  <menupopup>
    ...
    <hbox class="split-menuitem">
      <menuitem class="split-menuitem-item/>
      <menu class="split-menuitem-menu"/>
    </hbox>
    ...
  </menupopup>

or whatever you think is appropriate.  The key point being adding something to the hbox container and to the contained menuitem.

Comment 1

[Dão Gottwald [:dao]]

Sure, would you like to write the patch?

Comment 2

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #1)
> Sure, would you like to write the patch?

Thanks, that's a nice offer.  Unfortunately, I checked my build environment and I need to update .. all of it. (Source tree, sdk, and tools.)  It might only be a day or two before that's done, or it could end up being several days by the time all the wrinkles are ironed out.

In the mean time, there's not much to this bug, so if you want me to provide edited but untested files (or file) I could do that.

Either way, I'll check back in when I can build and test, and if not this time then maybe later.

Comment 3

[mcdavis941 (sporadically reading bugmail)]

Attachment: wip patch - adds classes

Very tiny patch.

If someone wants to suggest class names that better conform to naming conventions, I'll give it another go, but this seems reasonable.

I'm still running tests; I'll ask for review when that's done.

Comment 4

[mcdavis941 (sporadically reading bugmail)]

Comment on attachment 452861 [details] [diff] [review]
wip patch - adds classes

Asking Dao for review of the patch in comment 3.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/43b5dea56661

Comment 6

[Gomita]

Is there any chance to implement the new split menu in XBL (e.g. <menu type="split">)?
Current hbox + menuitem + menu implementation isn't versatile for extensions.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Is there any chance to implement the new split menu in XBL (e.g. <menu
> type="split">)?
> Current hbox + menuitem + menu implementation isn't versatile for extensions.

You should file a bug on it, first of all. The chance that it will happen will also dramatically increase if you contribute a patch. ;-)

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Is there any chance to implement the new split menu in XBL (e.g. <menu
> type="split">)?
> Current hbox + menuitem + menu implementation isn't versatile for extensions.

filed bug 613156