The default bug view has changed. See this FAQ.

Make use of Services.jsm in suite commandglue.js

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
MailNews: General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

Trunk
seamonkey2.1a2
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Changing services call to using Services.jsm.
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED

Comment 1

7 years ago
In suite glue that has been done, for other parts it needs to be done on a module-by-module basis, a general bug is useless and unwished.

What exactly are you proposing this bug to be about?
(Assignee)

Updated

7 years ago
Assignee: ewong → nobody
Component: Startup & Profiles → Backend
Product: SeaMonkey → MailNews Core
QA Contact: profile-manager → backend
Summary: Using Services.jsm as suite glue → Make use of Services.jsm inside c-c mailnews
Version: unspecified → Trunk
(Assignee)

Comment 2

7 years ago
I've changed the bug description and am now focusing on the c-c mailnews
component.
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
(Assignee)

Updated

7 years ago
Summary: Make use of Services.jsm inside c-c mailnews → Make use of Services.jsm in suite commandglue.js
(Assignee)

Comment 3

7 years ago
Created attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.
Attachment #452621 - Flags: review?(neil)
Comment on attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.

Stealing review, and looks good.
Attachment #452621 - Flags: review?(neil) → review+
Moving back to suite since its a suite-only file.
Component: Backend → MailNews: General
Product: MailNews Core → SeaMonkey
QA Contact: backend → mail

Comment 6

7 years ago
Comment on attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.

>+Components.utils.import("resource://gre/modules/Services.jsm");
Nit: don't need this because SeaMonkey already imports Services in utilityOverlay.js which all the main windows already overlay.
(Assignee)

Comment 7

7 years ago
Created attachment 452721 [details] [diff] [review]
Changed commandglue.js to use Services.jsm. r=Callek

As per comment 6, removed the unneeded line.
Attachment #452621 - Attachment is obsolete: true
Attachment #452721 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Updated

7 years ago
Attachment #452721 - Attachment description: Changed commandglue.js to use Services.jsm. → Changed commandglue.js to use Services.jsm. r=Callek
(In reply to comment #6)
> (From update of attachment 452621 [details] [diff] [review])
> >+Components.utils.import("resource://gre/modules/Services.jsm");
> Nit: don't need this because SeaMonkey already imports Services in
> utilityOverlay.js which all the main windows already overlay.

except prefwindow; but I don't think this is used there.
http://hg.mozilla.org/comm-central/rev/0fea9b945366
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
You need to log in before you can comment on or make changes to this bug.