Closed Bug 572080 Opened 15 years ago Closed 15 years ago

Make use of Services.jsm in suite commandglue.js

Categories

(SeaMonkey :: MailNews: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a2

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(1 file, 1 obsolete file)

Changing services call to using Services.jsm.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
In suite glue that has been done, for other parts it needs to be done on a module-by-module basis, a general bug is useless and unwished. What exactly are you proposing this bug to be about?
Assignee: ewong → nobody
Component: Startup & Profiles → Backend
Product: SeaMonkey → MailNews Core
QA Contact: profile-manager → backend
Summary: Using Services.jsm as suite glue → Make use of Services.jsm inside c-c mailnews
Version: unspecified → Trunk
I've changed the bug description and am now focusing on the c-c mailnews component.
Assignee: nobody → ewong
Summary: Make use of Services.jsm inside c-c mailnews → Make use of Services.jsm in suite commandglue.js
Attachment #452621 - Flags: review?(neil)
Comment on attachment 452621 [details] [diff] [review] Changed commandglue.js to use Services.jsm. Stealing review, and looks good.
Attachment #452621 - Flags: review?(neil) → review+
Moving back to suite since its a suite-only file.
Component: Backend → MailNews: General
Product: MailNews Core → SeaMonkey
QA Contact: backend → mail
Comment on attachment 452621 [details] [diff] [review] Changed commandglue.js to use Services.jsm. >+Components.utils.import("resource://gre/modules/Services.jsm"); Nit: don't need this because SeaMonkey already imports Services in utilityOverlay.js which all the main windows already overlay.
As per comment 6, removed the unneeded line.
Attachment #452621 - Attachment is obsolete: true
Attachment #452721 - Flags: review+
Keywords: checkin-needed
Attachment #452721 - Attachment description: Changed commandglue.js to use Services.jsm. → Changed commandglue.js to use Services.jsm. r=Callek
(In reply to comment #6) > (From update of attachment 452621 [details] [diff] [review]) > >+Components.utils.import("resource://gre/modules/Services.jsm"); > Nit: don't need this because SeaMonkey already imports Services in > utilityOverlay.js which all the main windows already overlay. except prefwindow; but I don't think this is used there.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: