Closed
Bug 572080
Opened 15 years ago
Closed 15 years ago
Make use of Services.jsm in suite commandglue.js
Categories
(SeaMonkey :: MailNews: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a2
People
(Reporter: ewong, Assigned: ewong)
Details
Attachments
(1 file, 1 obsolete file)
4.47 KB,
patch
|
ewong
:
review+
|
Details | Diff | Splinter Review |
Changing services call to using Services.jsm.
![]() |
Assignee | |
Updated•15 years ago
|
Assignee: nobody → ewong
![]() |
Assignee | |
Updated•15 years ago
|
Status: NEW → ASSIGNED
![]() |
||
Comment 1•15 years ago
|
||
In suite glue that has been done, for other parts it needs to be done on a module-by-module basis, a general bug is useless and unwished.
What exactly are you proposing this bug to be about?
![]() |
Assignee | |
Updated•15 years ago
|
Assignee: ewong → nobody
Component: Startup & Profiles → Backend
Product: SeaMonkey → MailNews Core
QA Contact: profile-manager → backend
Summary: Using Services.jsm as suite glue → Make use of Services.jsm inside c-c mailnews
Version: unspecified → Trunk
![]() |
Assignee | |
Comment 2•15 years ago
|
||
I've changed the bug description and am now focusing on the c-c mailnews
component.
![]() |
Assignee | |
Updated•15 years ago
|
Assignee: nobody → ewong
![]() |
Assignee | |
Updated•15 years ago
|
Summary: Make use of Services.jsm inside c-c mailnews → Make use of Services.jsm in suite commandglue.js
![]() |
Assignee | |
Comment 3•15 years ago
|
||
Attachment #452621 -
Flags: review?(neil)
Comment 4•15 years ago
|
||
Comment on attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.
Stealing review, and looks good.
Attachment #452621 -
Flags: review?(neil) → review+
Comment 5•15 years ago
|
||
Moving back to suite since its a suite-only file.
Component: Backend → MailNews: General
Product: MailNews Core → SeaMonkey
QA Contact: backend → mail
Comment 6•15 years ago
|
||
Comment on attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.
>+Components.utils.import("resource://gre/modules/Services.jsm");
Nit: don't need this because SeaMonkey already imports Services in utilityOverlay.js which all the main windows already overlay.
![]() |
Assignee | |
Comment 7•15 years ago
|
||
As per comment 6, removed the unneeded line.
Attachment #452621 -
Attachment is obsolete: true
Attachment #452721 -
Flags: review+
![]() |
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
![]() |
Assignee | |
Updated•15 years ago
|
Attachment #452721 -
Attachment description: Changed commandglue.js to use Services.jsm. → Changed commandglue.js to use Services.jsm. r=Callek
Comment 8•15 years ago
|
||
(In reply to comment #6)
> (From update of attachment 452621 [details] [diff] [review])
> >+Components.utils.import("resource://gre/modules/Services.jsm");
> Nit: don't need this because SeaMonkey already imports Services in
> utilityOverlay.js which all the main windows already overlay.
except prefwindow; but I don't think this is used there.
Comment 9•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
You need to log in
before you can comment on or make changes to this bug.
Description
•