Comment 1 Robert Kaiser 2010-06-15 04:02:57 PDT

In suite glue that has been done, for other parts it needs to be done on a module-by-module basis, a general bug is useless and unwished.

What exactly are you proposing this bug to be about?

Comment 2 Edmund Wong (:ewong) 2010-06-16 20:17:20 PDT

I've changed the bug description and am now focusing on the c-c mailnews
component.

Comment 3 Edmund Wong (:ewong) 2010-06-20 18:45:53 PDT

Created attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.

Comment 4 Justin Wood (:Callek) 2010-06-20 19:01:32 PDT

Comment on attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.

Stealing review, and looks good.

Comment 5 Justin Wood (:Callek) 2010-06-20 19:02:47 PDT

Moving back to suite since its a suite-only file.

Comment 6 neil@parkwaycc.co.uk 2010-06-21 05:15:59 PDT

Comment on attachment 452621 [details] [diff] [review]
Changed commandglue.js to use Services.jsm.

>+Components.utils.import("resource://gre/modules/Services.jsm");
Nit: don't need this because SeaMonkey already imports Services in utilityOverlay.js which all the main windows already overlay.

Comment 7 Edmund Wong (:ewong) 2010-06-21 07:50:58 PDT

Created attachment 452721 [details] [diff] [review]
Changed commandglue.js to use Services.jsm. r=Callek

As per comment 6, removed the unneeded line.

Comment 8 Justin Wood (:Callek) 2010-06-21 09:44:48 PDT

(In reply to comment #6)
> (From update of attachment 452621 [details] [diff] [review])
> >+Components.utils.import("resource://gre/modules/Services.jsm");
> Nit: don't need this because SeaMonkey already imports Services in
> utilityOverlay.js which all the main windows already overlay.

except prefwindow; but I don't think this is used there.

Comment 9 Justin Wood (:Callek) 2010-06-21 22:33:40 PDT

http://hg.mozilla.org/comm-central/rev/0fea9b945366