572094 - make nsMsgXFViewThread have a thread id

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[Ludovic Hirlimann [:Usul]]

from bug 538750 c 15

I think the idea was to make nsMsgXFViewThread have a thread id, and add a
method to the view that allows you to get the view thread object for a given
msg hdr. You can assign to me, but I don't know when I'm going to get to it.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

protz, can you try this and verify that it allows you to fix the other bug? If it does, I'll request reviews. And the other bug should have a test case that exercises this code...thx!

Comment 2

[[e-mail]]

Comment on attachment 452053 [details] [diff] [review]
proposed fix

>+   * view, then it would be the cross folder view thread, otherwise, the 
Nit: trailing whitespace

>-nsresult nsMsgSearchDBView::GetThreadContainingMsgHdr(nsIMsgDBHdr *msgHdr, 
>+NS_IMETHODIMP nsMsgSearchDBView::GetThreadContainingMsgHdr(nsIMsgDBHdr *msgHdr, 
Nit: kill the trailing whitespace while you're there.

>                                                       nsIMsgThread **pThread)
Nit: needs reindenting.

Comment 3

[David :Bienvenu]

fix checked in.

Comment 4

[Jonathan Protzenko [:protz]]

Comment on attachment 452053 [details] [diff] [review]
proposed fix

David, any chance we can try to fix that and bug 538750 on 3.1 as well?

Comment 5

[David :Bienvenu]

Jonathan, this patch can't go into 3.1.3 because it changes an interface. And in general, we mainly fix regressions and security issues in the point releases. But I think we should definitely get this into 3.2 if 3.2 ends up coming off the 1.9.2 branch.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 452053 [details] [diff] [review]
proposed fix

As David said, changing interfaces isn't allowed on stable branches. Shifting approval request to 3.2a1 flag.