572209 - cfx test-tab-browser.testAddTab (failure) error: fail: URL of new tab in the new window matches (null != "data:text/html,two")

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Nickolay_Ponomarev]

With both 3.6.3 and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a6pre) Gecko/20100615 Minefield/3.7a6pre and jetpack tip <http://hg.mozilla.org/labs/jetpack-sdk/pushloghtml?changeset=4cd03ad96e46> I get this error when running |cfx testall| or |cfx test| in packages/jetpack-core, but not when running the failing test individually via |cfx test -F tab|.

I have not yet investigated what might be causing it.

Does it work for everyone else?

jetpack-sdk/packages/jetpack-core$ cfx test -a firefox
[...]
error: TEST FAILED: test-tab-browser.testAddTab (failure)
error: fail: URL of new tab in the new window matches (null != "data:text/html,two")
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 57, in notify
    this._callback.apply(null, []);
  File "resource://jetpack-core-jetpack-core-lib/tab-browser.js", line 69, in anonymous
    callback(window, browsers[0]);
  File "resource://jetpack-core-jetpack-core-lib/tab-browser.js", line 111, in anonymous
    require("errors").catchAndLog(function(e) options.onLoad(e))(e);
  File "resource://jetpack-core-jetpack-core-lib/errors.js", line 49, in anonymous
    return callback.apply(this, arguments);
  File "resource://jetpack-core-jetpack-core-lib/tab-browser.js", line 111, in anonymous
    require("errors").catchAndLog(function(e) options.onLoad(e))(e);
  File "resource://jetpack-core-jetpack-core-tests/test-tab-browser.js", line 93, in anonymous
    test.assertEqual(cache[startWindowCount].content.location, secondUrl, "URL of new tab in the new window matches");
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 229, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 147, in fail
    console.trace();
............................................................................................................................................................................................................console: [JavaScript Error: "[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/browser.js :: FullZoom_destroy :: line 7385"  data: no]" {file: "chrome://browser/content/browser.js" line: 1319}]
console: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/browser.js :: BrowserShutdown :: line 1324"  data: no]"]
.....................................................................

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: v1

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 451783 [details] [diff] [review]
v1

The code looks good. It's hard to verify that it fixes the problem, given that the problem is intermittent, but I ran the tests a bunch of times with the patch applied and was unable to reproduce the problem, so it seems like the patch does indeed do the needful. r=myk!

Comment 3

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/labs/jetpack-sdk/rev/93180531b19d

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".