572258 - tracing+fatvals: Assert loading Dromaeo JS tests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

We assert at nsDOMClassInfo.cpp:9122:

        JS_ASSERT(false && "Relying on dirty private = int details");

This doesn't happen in a TM debug build, so I am assuming this is a can't-happen path and it is a bug in fatvals. Bad cx->resolveFlags is suspected.

Comment 1

[Luke Wagner [:luke]]

Actually, I think it is safe to remove that assert: I added it when I first saw some gross jsval/private mucking and when I fixed the issue with the FlagsToPrivate/PrivateToFlags functions I just forgot to remove the assert.

Comment 2

[David Mandelin [:dmandelin]]

Cool. Thanks.

http://hg.mozilla.org/users/lwagner_mozilla.com/fatval/rev/f92919e945ae