Closed
Bug 572587
Opened 14 years ago
Closed 14 years ago
Starring suggestions should highlight/bold the matching portion of the error messagae
Categories
(Tree Management Graveyard :: TBPL, enhancement)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
3.12 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Starring suggestions key based on the test name. To make it easier to tell whether it's the same failure (and not another failure in the same test), the matching part of the error message should be highlighted. Would make it easier to tell that this *isn't* the correct bug: TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_bug356571.js | application timed out after 330 seconds with no output Bug 545584 - Intermittent failure in browser_bug356571.js | Correctly opened all expected tabs
Assignee | ||
Comment 1•14 years ago
|
||
Highlight the matches in the bug summary, and give closed bugs more visibility by underlining the entire row. See http://ehsanakhgari.org/tinderboxpushlog/index.html to see how it looks.
Assignee | ||
Comment 2•14 years ago
|
||
On second thought, using global and case insensitive match would probably give better highlighting results.
Attachment #451792 -
Attachment is obsolete: true
Attachment #451793 -
Flags: review?(mstange)
Attachment #451792 -
Flags: review?(mstange)
Updated•14 years ago
|
Attachment #451793 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/013f50d410a4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•14 years ago
|
||
I pushed this as a followup to this bug, to fix the html code displaying inside summaries. http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d412cccd5fb7 I'm not sure why this didn't happen on my instance, but my testing inside Firebug shows that it should fix the problem.
Comment 5•14 years ago
|
||
I don't understand why this happened and why that fixed it. Deployed.
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #5) > I don't understand why this happened and why that fixed it. Deployed. Well, we were basically replacing the empty string with span tags over and over again. See bug 574516 for a similar problem.
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•