Starring suggestions should highlight/bold the matching portion of the error messagae

RESOLVED FIXED

Status

Tree Management Graveyard
TBPL
--
enhancement
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: Jesse Ruderman, Assigned: Ehsan)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Starring suggestions key based on the test name.  To make it easier to tell whether it's the same failure (and not another failure in the same test), the matching part of the error message should be highlighted.

Would make it easier to tell that this *isn't* the correct bug:

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_bug356571.js | application timed out after 330 seconds with no output
    Bug 545584 - Intermittent failure in browser_bug356571.js | Correctly opened all expected tabs
(Assignee)

Comment 1

8 years ago
Created attachment 451792 [details] [diff] [review]
Patch (v1)

Highlight the matches in the bug summary, and give closed bugs more visibility by underlining the entire row.

See http://ehsanakhgari.org/tinderboxpushlog/index.html to see how it looks.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #451792 - Flags: review?(mstange)
(Assignee)

Comment 2

8 years ago
Created attachment 451793 [details] [diff] [review]
Patch (v1.1)

On second thought, using global and case insensitive match would probably give better highlighting results.
Attachment #451792 - Attachment is obsolete: true
Attachment #451793 - Flags: review?(mstange)
Attachment #451792 - Flags: review?(mstange)
Attachment #451793 - Flags: review?(mstange) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/013f50d410a4
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

8 years ago
I pushed this as a followup to this bug, to fix the html code displaying inside summaries.

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d412cccd5fb7

I'm not sure why this didn't happen on my instance, but my testing inside Firebug shows that it should fix the problem.
I don't understand why this happened and why that fixed it. Deployed.
(Assignee)

Updated

8 years ago
Depends on: 574516
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> I don't understand why this happened and why that fixed it. Deployed.

Well, we were basically replacing the empty string with span tags over and over again.  See bug 574516 for a similar problem.
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.