572635 - Configure needs to have --disable-webm for non-audio environment besides --disable-wave and --disable-ogg

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[ISHIKAWA, Chiaki]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: 3.2a1pre

I have been building  TB3 (3.2a1pre) using comm-central for some time.

However, configure failed suddenly lately.

I found out that --disable-webm needs to be specified now in MOZCONFIG file
on top of --disable-wave and --disable-ogg when 
alsa sound package is not loaded. (The target PC is not equipeed with sound card and I didn't think it was necessary to enable audio for this build.)

A few weeks before, I could build TB3 using only 
ac_add_options --disable-ogg
ac_add_options --disable-wave

in MOZCONFIG file.

It turns out that the latest comm-central code requires
the additional disabling of webm feature by the  following:

ac_add_options --disable-webm

MOZ_SYDNEYAUDIO, whatever it stands for, gets set if webm feature is used,
and this MOZ_SYDNEYAUDIO is checked to see if alsa package is needed.

I would like the configure to explain what to do and so modified the comment
that is printed when alsa is not found under linux.

(Opening this bugzilla entry was suggested in
https://bugzilla.mozilla.org/show_bug.cgi?id=570882#c28
)


-- 

Reproducible: Always

Steps to Reproduce:
1. On a linux PC without alsa package, prepare a fresh install of TB3 source files from comm-central.
2. Update to the latest source by "python client.py checktout"
   Make sure you have 
ac_add_options --disable-ogg
ac_add_options --disable-wave
in $MOZCONFIG file.

3. run make -f client.mk build
Actual Results:  
configure failed.

Expected Results:  
configure should succeed or should mention that I need --disable-webm additionally on top of 
--disable-ogg and --disable-wave.

Comment 1

[ISHIKAWA, Chiaki]

I tried to enter this as TB3 bug entry, but then I could not choose
Core -> Video/Audio entry, it seems.
From the comment  : https://bugzilla.mozilla.org/show_bug.cgi?id=570882#c28
"Changing the ALSA error message to suggest --disable-webm is fine. Could you
file a separate bug in Core -> Video/Audio with your patch please?"

Anyway, I am attaching a patch to mozilla/configure.in

TIA

Comment 2

[ISHIKAWA, Chiaki]

Attachment: Patch to improve comment in mozilla/configure.in

(Oh, as I tried to change the product to core , then when I hit commit button for the previous message, I was advised to choose the proper component and then I could choose video/audio.)

Comment 3

[cajbir (:cajbir)]

+          AC_MSG_ERROR([Need alsa for Ogg, Wave or VP8 decoding on Linux.  

This should probably say 'WebM' instead of 'VP8'.

Comment 4

[ISHIKAWA, Chiaki]

Attachment: Patch to improve comment in mozilla/configure.in

Modified VP8 to WebM as suggested in the recent comment.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 452037 [details] [diff] [review]
Patch to improve comment in mozilla/configure.in

Ted's the best person to review this.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d9e7027f52cc